Add test to verify models and inputs are using the expected device#443
Merged
Conversation
The device attribute needs to be set in three locations: the BenchmarkModel, the nn.Module model, and the model inputs. This test will verify that the tensors and inputs are on the expected device set in BenchmarkModel. Also, fix a few benchmark bugs where the device is incorrectly set.
Member
Author
|
Verified this test with |
xuzhao9
approved these changes
Sep 1, 2021
Contributor
xuzhao9
left a comment
xuzhao9
left a comment
There was a problem hiding this comment.
Overall looks good to me! Great to see the test is already capturing a few bugs!
robieta
requested changes
Sep 2, 2021
robieta
left a comment
robieta
left a comment
There was a problem hiding this comment.
I had some nitpicks, but overall looks quite reasonable. And that fact that it's already catching bugs speaks volumes! Thanks!
Change Exception to RuntimeError. Update check inputs to a recursive implementation.
robieta
approved these changes
Sep 2, 2021
robieta
left a comment
robieta
left a comment
There was a problem hiding this comment.
One minor nit, but overall LGTM. Thanks!
xuzhao9
pushed a commit
to xuzhao9/benchmark
that referenced
this pull request
Sep 10, 2021
…ytorch#443) * Add test to verify models and inputs are using the expected device The device attribute needs to be set in three locations: the BenchmarkModel, the nn.Module model, and the model inputs. This test will verify that the tensors and inputs are on the expected device set in BenchmarkModel. Also, fix a few benchmark bugs where the device is incorrectly set. * Fix a bug in tts_angular benchmark not allocating inputs on expected device * Minor improvements to check_device Change Exception to RuntimeError. Update check inputs to a recursive implementation. * Fix small mistake for inputs tensor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device attribute needs to be set in three locations: the BenchmarkModel,
the nn.Module model, and the model inputs. This test will verify that
the tensors and inputs are on the expected device set in BenchmarkModel.
Also, fix a few benchmark bugs where the device is incorrectly set.