Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rnns/fastrnns/bench.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ def bench(rnn_runners, group_name, print_json=False, sep=' ', **params):
args = parser.parse_args()
rnns = args.rnns or ['cudnn', 'aten', 'jit', 'jit_premul', 'jit_simple',
'jit_multilayer', 'py']
# TODO: Maybe add a separate section for the layernorm lstms
# 'jit_layernorm', 'jit_layernom_decom', 'jit'
# TODO: Maybe add a separate section for the layernorm/dropout lstms
# 'jit_layernorm', 'jit_layernom_decom', 'jit', 'jit_dropout', 'cudnn_dropout'
vlrnns = ['vl_cudnn', 'vl_jit', 'vl_py']
cnns = ['resnet18', 'resnet18_jit', 'resnet50', 'resnet50_jit']
if args.print_json:
Expand Down
11 changes: 9 additions & 2 deletions rnns/fastrnns/custom_lstms.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import torch.nn as nn
from torch.nn import Parameter
import torch.jit as jit
import warnings
from collections import namedtuple
from typing import List, Tuple
from torch import Tensor
Expand Down Expand Up @@ -306,12 +307,18 @@ class StackedLSTMWithDropout(jit.ScriptModule):
__constants__ = ['layers', 'num_layers']

def __init__(self, num_layers, layer, first_layer_args, other_layer_args):
super(StackedLSTM, self).__init__()
super(StackedLSTMWithDropout, self).__init__()
self.layers = init_stacked_lstm(num_layers, layer, first_layer_args,
other_layer_args)
# Introduces a Dropout layer on the outputs of each LSTM layer except
# the last layer, with dropout probability = 0.4.
self.num_layers = num_layers

if (num_layers == 1):
warnings.warn("dropout lstm adds dropout layers after all but last "
"recurrent layer, it expects num_layers greater than "
"1, but got num_layers = 1")

self.dropout_layer = nn.Dropout(0.4)

@jit.script_method
Expand All @@ -327,7 +334,7 @@ def forward(self, input, states):
output, out_state = rnn_layer(output, state)
# Apply the dropout layer except the last layer
if i < self.num_layers - 1:
output = self.dropout_layer(output)
output = self.dropout_layer(output)
output_states += [out_state]
i += 1
return output, output_states
Expand Down
26 changes: 24 additions & 2 deletions rnns/fastrnns/factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,28 @@ def lnlstm_creator(script=True, decompose_layernorm=False, **kwargs):
backward=simple_backward)


def dropoutlstm_creator(script=True, **kwargs):
assert script is True
from .custom_lstms import script_lstm, LSTMState
input_size = kwargs['inputSize']
hidden_size = kwargs['hiddenSize']
seq_len = kwargs['seqLength']
batch_size = kwargs['miniBatch']
num_layers = kwargs['numLayers']
ge = script_lstm(input_size, hidden_size, num_layers, dropout=True).cuda()

input = torch.randn(seq_len, batch_size, input_size, device='cuda')
states = [LSTMState(torch.randn(batch_size, hidden_size, device='cuda'),
torch.randn(batch_size, hidden_size, device='cuda'))
for _ in range(num_layers)]
return ModelDef(
inputs=[input, states],
params=ge.parameters(),
forward=ge,
backward_setup=lstm_backward_setup,
backward=simple_backward)


def lstm_premul_creator(script=True, **kwargs):
input, hidden, params, _ = lstm_inputs(return_module=False, **kwargs)
inputs = [input, hidden] + params[0]
Expand Down Expand Up @@ -270,13 +292,13 @@ def unzip_columns(mat):

# returns: x, (hx, cx), all_weights, lstm module with all_weights as params
def lstm_inputs(seqLength=100, numLayers=1, inputSize=512, hiddenSize=512,
miniBatch=64, return_module=False, device='cuda', seed=None):
miniBatch=64, dropout=0.0, return_module=False, device='cuda', seed=None):
if seed is not None:
torch.manual_seed(seed)
x = torch.randn(seqLength, miniBatch, inputSize, device=device)
hx = torch.randn(numLayers, miniBatch, hiddenSize, device=device)
cx = torch.randn(numLayers, miniBatch, hiddenSize, device=device)
lstm = torch.nn.LSTM(inputSize, hiddenSize, numLayers)
lstm = torch.nn.LSTM(inputSize, hiddenSize, numLayers, dropout=dropout)
if 'cuda' in device:
lstm = lstm.cuda()

Expand Down
2 changes: 2 additions & 0 deletions rnns/fastrnns/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def get_rnn_runners(*names):

rnn_runners = {
'cudnn': RNNRunner('cudnn', pytorch_lstm_creator, DummyContext),
'cudnn_dropout': RNNRunner('cudnn_dropout', partial(pytorch_lstm_creator, dropout=0.4), DummyContext),
'vl_cudnn': RNNRunner('vl_cudnn', varlen_pytorch_lstm_creator, DummyContext),
'vl_jit': RNNRunner('vl_jit', partial(varlen_lstm_creator, script=True), DummyContext),
'vl_py': RNNRunner('vl_py', varlen_lstm_creator, DummyContext),
Expand All @@ -56,6 +57,7 @@ def get_rnn_runners(*names):
'jit_layernorm_decom': RNNRunner('jit_layernorm_decom',
partial(lnlstm_creator, decompose_layernorm=True),
DummyContext),
'jit_dropout': RNNRunner('jit_dropout', dropoutlstm_creator, DummyContext),
'py': RNNRunner('py', partial(lstm_creator, script=False), DummyContext),
'resnet18': RNNRunner('resnet18', imagenet_cnn_creator(cnn.resnet18, jit=False), DummyContext),
'resnet18_jit': RNNRunner('resnet18_jit', imagenet_cnn_creator(cnn.resnet18), DummyContext),
Expand Down