This repository was archived by the owner on Aug 15, 2025. It is now read-only.
add ROCm 3.9 manywheel build #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walterddr could you please review? Thanks. |
walterddr
reviewed
Oct 29, 2020
| if [[ $ROCM_VERSION == "rocm3.7" ]]; then | ||
| TENSILE_LIBRARY_NAME=TensileLibrary.yaml | ||
| elif [[ $ROCM_VERSION == "rocm3.8" ]]; then | ||
| else |
There was a problem hiding this comment.
Suggested change
| else | |
| elif [[ $ROCM_VERSION == "rocm3.8" || $ROCM_VERSION == "rocm3.9" ]]; then |
There was a problem hiding this comment.
I did consider that, but IIUC the tensile library name extension will hereafter always be *.dat, so the rocm3.7 case was the only exceptional case.
There was a problem hiding this comment.
got it. thanks for the explanation
walterddr
approved these changes
Oct 30, 2020
|
@jeffdaily did you have rocm3.9 docker images created? |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 2, 2020
Summary: Corresponding pytorch builder repo update: pytorch/builder#561. Pull Request resolved: #47121 Reviewed By: samestep Differential Revision: D24660850 Pulled By: walterddr fbshipit-source-id: 68b22e0a2d341396eb1cdcfaa0a413ce7ad93ca3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.