Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

add ROCm 3.9 manywheel build #561

Merged
merged 3 commits into from
Oct 30, 2020
Merged

add ROCm 3.9 manywheel build #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8923c4d
add rocm 3.9 to manywheel/deploy.sh
jeffdaily Oct 29, 2020
afdc83a
update manywheel/build_rocm.sh for rocm 3.9
jeffdaily Oct 29, 2020
83d262e
update cron/update_s3_htmls.sh for rocm 3.9
jeffdaily Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cron/update_s3_htmls.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ set -e

# Upload for all CUDA/cpu versions if not given one to use
if [[ -z "$CUDA_VERSIONS" ]]; then
export CUDA_VERSIONS=('cpu' 'cu92' 'cu100' 'cu101' 'cu102' 'cu110' 'rocm3.7' 'rocm3.8')
export CUDA_VERSIONS=('cpu' 'cu92' 'cu100' 'cu101' 'cu102' 'cu110' 'rocm3.7' 'rocm3.8' 'rocm3.9')
fi

if [[ -z "$HTML_NAME" ]]; then
Expand Down
17 changes: 13 additions & 4 deletions manywheel/build_rocm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,22 +59,31 @@ elif [[ "$OS_NAME" == *"Ubuntu"* ]]; then
LIBELF_PATH="/usr/lib/x86_64-linux-gnu/libelf.so.1"
fi

# rocm3.8 and later use TensileLibrary.dat
if [[ $ROCM_VERSION == "rocm3.7" ]]; then
TENSILE_LIBRARY_NAME=TensileLibrary.yaml
elif [[ $ROCM_VERSION == "rocm3.8" ]]; then
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else
elif [[ $ROCM_VERSION == "rocm3.8" || $ROCM_VERSION == "rocm3.9" ]]; then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did consider that, but IIUC the tensile library name extension will hereafter always be *.dat, so the rocm3.7 case was the only exceptional case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. thanks for the explanation

TENSILE_LIBRARY_NAME=TensileLibrary.dat
fi

# NOTE: Some ROCm versions have identical dependencies.
# To avoid copy/paste mistakes, version condition branches are combined.
# in rocm3.9, libamd_comgr path changed from lib to lib64
if [[ $ROCM_VERSION == "rocm3.7" || $ROCM_VERSION == "rocm3.8" ]]; then
COMGR_LIBDIR="lib"
else
COMGR_LIBDIR="lib64"
fi

# NOTE: Some ROCm versions have identical dependencies, or very close deps.
# To avoid copy/paste mistakes, version condition branches are combined.
if [[ $ROCM_VERSION == "rocm3.7" || $ROCM_VERSION == "rocm3.8" || $ROCM_VERSION == "rocm3.9" ]]; then

DEPS_LIST=(
"/opt/rocm/miopen/lib/libMIOpen.so.1"
"/opt/rocm/hip/lib/libamdhip64.so.3"
"/opt/rocm/hiprand/lib/libhiprand.so.1"
"/opt/rocm/hipsparse/lib/libhipsparse.so.0"
"/opt/rocm/hsa/lib/libhsa-runtime64.so.1"
"/opt/rocm/lib/libamd_comgr.so.1"
"/opt/rocm/${COMGR_LIBDIR}/libamd_comgr.so.1"
"/opt/rocm/lib64/libhsakmt.so.1"
"/opt/rocm/rccl/lib/librccl.so.1"
"/opt/rocm/rocblas/lib/librocblas.so.0"
Expand Down
2 changes: 1 addition & 1 deletion manywheel/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -eou pipefail

for rocm_version in 3.7 3.8; do
for rocm_version in 3.7 3.8 3.9; do
(
set -x
DOCKER_BUILDKIT=1 docker build \
Expand Down