Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Conversation

pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Apr 23, 2021

Stack from ghstack:

pbelevich added a commit that referenced this pull request Apr 23, 2021
ghstack-source-id: 62f90c4
Pull Request resolved: #711
ADD ./common/install_mnist.sh install_mnist.sh
RUN bash ./install_mnist.sh

FROM base as openssl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put if after MNIST because MNIST is not available

cd ${OPENSSL}
./config -d '-Wl,--enable-new-dtags,-rpath,$(LIBRPATH)'
make install
make install_sw # Only install the OpenSSL software components.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need man pages

pbelevich added a commit that referenced this pull request Apr 23, 2021
ghstack-source-id: cf3e0fa
Pull Request resolved: #711
# (In order to have a proper SSL module, Python is compiled
# against a recent openssl [see env vars above], which is linked
# statically. We delete openssl afterwards.)
build_openssl $OPENSSL_ROOT $OPENSSL_HASH
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPython won't build without it:

+ /opt/_internal/cpython-3.6.6/bin/python get-pip.py
WARNING: pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available.
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.",)': /simple/pip/

function do_openssl_build {
./config -d '-Wl,--enable-new-dtags,-rpath,$(LIBRPATH)' > /dev/null
make install > /dev/null
./config no-ssl2 no-shared -fPIC --prefix=/usr/local/ssl > /dev/null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPython builds fail if it's not no-shared --prefix=/usr/local/ssl

@pbelevich pbelevich requested a review from seemethere April 23, 2021 22:00
@pbelevich pbelevich changed the title Fix OpenSSL 1.1.1k for manywheel/conda/libtorch [DO NOT MERGE]Fix OpenSSL 1.1.1k for manywheel/conda/libtorch Apr 23, 2021
@seemethere
Copy link
Member

Superseded by #712

@seemethere seemethere closed this Apr 28, 2021
@facebook-github-bot facebook-github-bot deleted the gh/pbelevich/4/head branch May 29, 2021 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants