This repository was archived by the owner on Aug 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 228
[DO NOT MERGE]Fix OpenSSL 1.1.1k for manywheel/conda/libtorch #711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pbelevich
commented
Apr 23, 2021
ADD ./common/install_mnist.sh install_mnist.sh | ||
RUN bash ./install_mnist.sh | ||
|
||
FROM base as openssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put if after MNIST because MNIST is not available
pbelevich
commented
Apr 23, 2021
cd ${OPENSSL} | ||
./config -d '-Wl,--enable-new-dtags,-rpath,$(LIBRPATH)' | ||
make install | ||
make install_sw # Only install the OpenSSL software components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need man pages
[ghstack-poisoned]
pbelevich
commented
Apr 23, 2021
# (In order to have a proper SSL module, Python is compiled | ||
# against a recent openssl [see env vars above], which is linked | ||
# statically. We delete openssl afterwards.) | ||
build_openssl $OPENSSL_ROOT $OPENSSL_HASH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPython won't build without it:
+ /opt/_internal/cpython-3.6.6/bin/python get-pip.py
WARNING: pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available.
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.",)': /simple/pip/
pbelevich
commented
Apr 23, 2021
function do_openssl_build { | ||
./config -d '-Wl,--enable-new-dtags,-rpath,$(LIBRPATH)' > /dev/null | ||
make install > /dev/null | ||
./config no-ssl2 no-shared -fPIC --prefix=/usr/local/ssl > /dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPython builds fail if it's not no-shared --prefix=/usr/local/ssl
Superseded by #712 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack: