This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Various dockerfile fixes #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
commented
Apr 23, 2021
|
|
||
|
|
||
| FROM scratch as final | ||
| FROM alpine as final |
There was a problem hiding this comment.
This adds some bulk to the builds, but makes it easier to debug if needing to inspect the image itself
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
force-pushed
the
fix_dockerfile_builds
branch
from
5e58aab to
8fa56a7
Compare
bertmaher
approved these changes
Apr 23, 2021
bertmaher
approved these changes
Apr 23, 2021
malfet
approved these changes
Apr 23, 2021
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Apr 28, 2021
Adds /opt/openssl v1.1.1 to cpu CI images to enable testing for Gloo TCP_TLS Similar to pytorch/builder#712 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 28, 2021
Summary: Pull Request resolved: #57071 Adds /opt/openssl v1.1.1 to cpu CI images to enable testing for Gloo TCP_TLS Similar to pytorch/builder#712 Enables #56442 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Test Plan: Imported from OSS Reviewed By: malfet Differential Revision: D28061203 Pulled By: seemethere fbshipit-source-id: 222a824b30de96c1064da11ce8ce4dc6c851111e
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#57071 Adds /opt/openssl v1.1.1 to cpu CI images to enable testing for Gloo TCP_TLS Similar to pytorch/builder#712 Enables pytorch#56442 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Test Plan: Imported from OSS Reviewed By: malfet Differential Revision: D28061203 Pulled By: seemethere fbshipit-source-id: 222a824b30de96c1064da11ce8ce4dc6c851111e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eli Uriegas eliuriegas@fb.com