Create Jupyter widget for Captum Insights#124
Conversation
|
Awesome! I'll give it a more thorough review tomorrow, can you check why the tests are failing? |
e59abb1 to
8d5c707
Compare
edward-io
left a comment
There was a problem hiding this comment.
This is fantastic! Thanks for working on this. Looks good to me.
Can you format your Javascript code using Prettier?
| button { | ||
| cursor: pointer; | ||
| } | ||
|
|
There was a problem hiding this comment.
why leave this here? should we just move it all into the css module?
There was a problem hiding this comment.
I believe the main purpose of CSS modules is to allow locally scoped styles linked to classnames. For that reason, I put all class-specific styles in the App.module.css file and all global styles in App.css. A CSS selector like this isn't directly accessible by CSS modules since there's no classname tied to it.
Example: if we import the CSS modules like so:
import styles from "./App.module.css";
You can't refer to styles.button, but you can use styles.btn since .btn is a classname.
That being said, global styles like button { ... } will still work as expected when placed in a CSS modules file.
There was a problem hiding this comment.
I'm wondering if we should move this into the .btn class, does it influence the Jupyter notebook at all?
There was a problem hiding this comment.
I believe the Jupyter notebook buttons are already styled to have cursor: pointer;, but I think it would be more proper to scope this locally in the .btn class.
a6d0139 to
b8f504c
Compare
|
Formatted JS code with Prettier and moved WebApp react component to its own file. |
|
Rebase to master and resolve the merge conflicts please :) Otherwise, LGTM. |
Create Jupyter widget for Captum Insights
servethe webapp orrenderthe widget