Fix for Captum to be served in Colab notebooks#255
Closed
J0Nreynolds wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19590439 |
J0Nreynolds
force-pushed
the
export-D19590439
branch
from
3ad466a to
e9f6fa0
Compare
J0Nreynolds
added a commit
to J0Nreynolds/captum
that referenced
this pull request
Feb 5, 2020
Summary: Pull Request resolved: meta-pytorch#255 This change uses TensorBoard's example of Colab serving to support serving Captum Insights in Colab. The main changes are: - Display a script in Colab which does the following upon execution - Set the base URL to localhost:PORT where PORT is the port that the Insights server is using (this ensures requests are directed properly) - Fetch "." and get the HTML response - Insert the HTML into the DOM - For each script and css file in the HTML, remove and reinsert them in DOM to force them to be loaded. - Replace request.json with request.get_json(force=True). This is necessary since Colab doesn't respect Content-Type header when forwarding requests through proxy, and force=True forces the request body to be parsed as JSON Reviewed By: edward-io Differential Revision: D19590439 fbshipit-source-id: fc5cad83780db35076071555318abfc5b746b620
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19590439 |
Contributor
Author
|
All failures are due to linter error: However, we need to import google.colab in order to test for notebook context. All changes have been retested in Colab, and the widget functions properly. |
edward-io
reviewed
Feb 5, 2020
| # returned by `IPython.get_ipython` does not have a `get_trait` | ||
| # method. | ||
| try: | ||
| import google.colab |
Contributor
There was a problem hiding this comment.
We can add # noqa: F401 to the end of the import line to silence linter errors.
J0Nreynolds
added a commit
to J0Nreynolds/captum
that referenced
this pull request
Feb 6, 2020
Summary: Pull Request resolved: meta-pytorch#255 This change uses TensorBoard's example of Colab serving to support serving Captum Insights in Colab. The main changes are: - Display a script in Colab which does the following upon execution - Set the base URL to localhost:PORT where PORT is the port that the Insights server is using (this ensures requests are directed properly) - Fetch "." and get the HTML response - Insert the HTML into the DOM - For each script and css file in the HTML, remove and reinsert them in DOM to force them to be loaded. - Replace request.json with request.get_json(force=True). This is necessary since Colab doesn't respect Content-Type header when forwarding requests through proxy, and force=True forces the request body to be parsed as JSON Reviewed By: edward-io Differential Revision: D19590439 fbshipit-source-id: 40f4d951256f36390f28bcfa10e0751938054dbc
J0Nreynolds
force-pushed
the
export-D19590439
branch
from
e9f6fa0 to
cb0d726
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19590439 |
J0Nreynolds
added a commit
to J0Nreynolds/captum
that referenced
this pull request
Feb 6, 2020
Summary: Pull Request resolved: meta-pytorch#255 This change uses TensorBoard's example of Colab serving to support serving Captum Insights in Colab. The main changes are: - Display a script in Colab which does the following upon execution - Set the base URL to localhost:PORT where PORT is the port that the Insights server is using (this ensures requests are directed properly) - Fetch "." and get the HTML response - Insert the HTML into the DOM - For each script and css file in the HTML, remove and reinsert them in DOM to force them to be loaded. - Replace request.json with request.get_json(force=True). This is necessary since Colab doesn't respect Content-Type header when forwarding requests through proxy, and force=True forces the request body to be parsed as JSON Reviewed By: edward-io Differential Revision: D19590439 fbshipit-source-id: 1cbd835e51cd31ea8287335c3234b16f506b719b
J0Nreynolds
force-pushed
the
export-D19590439
branch
from
cb0d726 to
f82fcb3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19590439 |
Summary: Pull Request resolved: meta-pytorch#255 This change uses TensorBoard's example of Colab serving to support serving Captum Insights in Colab. The main changes are: - Display a script in Colab which does the following upon execution - Set the base URL to localhost:PORT where PORT is the port that the Insights server is using (this ensures requests are directed properly) - Fetch "." and get the HTML response - Insert the HTML into the DOM - For each script and css file in the HTML, remove and reinsert them in DOM to force them to be loaded. - Replace request.json with request.get_json(force=True). This is necessary since Colab doesn't respect Content-Type header when forwarding requests through proxy, and force=True forces the request body to be parsed as JSON Reviewed By: edward-io Differential Revision: D19590439 fbshipit-source-id: 51893cd6f77aa6fd77f19e70c946cdefe2895f33
J0Nreynolds
force-pushed
the
export-D19590439
branch
from
f82fcb3 to
2011099
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D19590439 |
Contributor
|
This pull request has been merged in 22cb33b. |
NarineK
pushed a commit
to NarineK/captum-1
that referenced
this pull request
Nov 19, 2020
Summary: Pull Request resolved: meta-pytorch#255 This change uses TensorBoard's example of Colab serving to support serving Captum Insights in Colab. The main changes are: - Display a script in Colab which does the following upon execution - Set the base URL to localhost:PORT where PORT is the port that the Insights server is using (this ensures requests are directed properly) - Fetch "." and get the HTML response - Insert the HTML into the DOM - For each script and css file in the HTML, remove and reinsert them in DOM to force them to be loaded. - Replace request.json with request.get_json(force=True). This is necessary since Colab doesn't respect Content-Type header when forwarding requests through proxy, and force=True forces the request body to be parsed as JSON Reviewed By: edward-io Differential Revision: D19590439 fbshipit-source-id: 53d2180321ceb710ac2c06d0859c4913f4d01040
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change uses TensorBoard's example of Colab serving to support serving Captum Insights in Colab. The main changes are:
Differential Revision: D19590439