Arm backend: Convert asserts to raise errors in op_minimum #10055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asserts are converted to proper raises to ensure graph integrity. Improve error messages and add additional check that both inputs and outputs have the same data type. Change-Id: I1bc2f001f1a5a75a57468263bc5343de1476b90f Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10055
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit b234c98 with merge base 91a14f1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Sebastian-Larsson
added
ciflow/trunk
partner: arm
zingo
approved these changes
Apr 11, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Asserts are converted to proper raises to ensure graph integrity. Improve error messages and add additional check that both inputs and outputs have the same data type. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
…0055) Asserts are converted to proper raises to ensure graph integrity. Improve error messages and add additional check that both inputs and outputs have the same data type. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asserts are converted to proper raises to ensure graph integrity.
Improve error messages and add additional check that both inputs and outputs have the same data type.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218