-
Notifications
You must be signed in to change notification settings - Fork 741
: constant fold None #10755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
: constant fold None #10755
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10755
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New FailuresAs of commit 92cd06d with merge base ee6cf99 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74280168 |
This PR needs a
|
Summary: Constant folding should fold 'None' and consider it a constant Reviewed By: dulinriley Differential Revision: D74280168
a976d9b to
d1a7f97
Compare
Summary: Pull Request resolved: pytorch#10755 Constant folding should fold 'None' and consider it a constant Reviewed By: dulinriley Differential Revision: D74280168
|
This pull request was exported from Phabricator. Differential Revision: D74280168 |
d1a7f97 to
92cd06d
Compare
|
Sorry for the late review. Can you add some context on this? Does const_prop not trigger if one of the args is None? Can you add a unit test that wouldve failed before this change? |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
closed in favor of #10762 |
Summary: Constant folding should fold 'None' and consider it a constant
Differential Revision: D74280168