Skip to content

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Jul 31, 2025

  • Executorch may be cross compiled for arm-baremetal targets using 'cmake --preset arm-baremetal'
  • Adds a new flag EXECUTORCH_BUILD_ARM_ETDUMP used in the preset to easy enabling of ET_DUMP.
  • backend/arm/scripts/build_executorch.sh is updated to use the new preset with same behaviour as before.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Executorch may be cross compiled for arm-baremetal targets using
  'cmake --preset arm-baremetal'
- Adds a new flag EXECUTORCH_BUILD_ARM_ETDUMP used in the preset
  to easy enabling of ET_DUMP.
- backend/arm/scripts/build_executorch.sh is updated to use the new
  preset with same behaviour as before.

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Change-Id: I86408f8d97c99d05ebb6c55242ac4c361411d4db
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Jul 31, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13042

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 2880783 with merge base bedce91 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 31, 2025
@@ -0,0 +1,25 @@
# Copyright 2025 Arm Limited and/or its affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though this PR is OK, I want to brainstorm here a bit more.

There are two, I think, orthogonal things we are mixing here, (1) Arm-ness, (2) Baremetal-ness. Can we split? For the preset its OK, I am talking about things like EXECUTORCH_BUILD_ARM_BAREMETAL the things it guards are not strictly related to Arm.

This will come up when we try to do Arm Cortex-m + Ethos on Zephyr. Passing ARM_BAREMETAL would be confusing at best.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, changing it to something like EXECUTORCH_BUILD_ARM_ETHOSU seems reasonable to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess depends on the things we want to guard with this build flavor. We need to split this EXEUCTORCH_BUILD_ARM_BAREMETAL into EXECUTORCH_BUILD_ARM_ETHOSU and EXECUTORCH_BUILD_BAREMETAL. I can also see Cortex-M (no NPU) builds and not sure if the ETHOSU is the right suffix either.

@zingo zingo merged commit 8d0053c into pytorch:main Aug 4, 2025
224 of 228 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
- Executorch may be cross compiled for arm-baremetal targets using
'cmake --preset arm-baremetal'
- Adds a new flag EXECUTORCH_BUILD_ARM_ETDUMP used in the preset to easy
enabling of ET_DUMP.
- backend/arm/scripts/build_executorch.sh is updated to use the new
preset with same behaviour as before.

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
@AdrianLundell AdrianLundell deleted the change-1080841 branch September 4, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants