-
Notifications
You must be signed in to change notification settings - Fork 733
Arm backend: Add arm-baremetal CMake preset #13042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Executorch may be cross compiled for arm-baremetal targets using 'cmake --preset arm-baremetal' - Adds a new flag EXECUTORCH_BUILD_ARM_ETDUMP used in the preset to easy enabling of ET_DUMP. - backend/arm/scripts/build_executorch.sh is updated to use the new preset with same behaviour as before. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I86408f8d97c99d05ebb6c55242ac4c361411d4db
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13042
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2880783 with merge base bedce91 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @@ -0,0 +1,25 @@ | |||
| # Copyright 2025 Arm Limited and/or its affiliates. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though this PR is OK, I want to brainstorm here a bit more.
There are two, I think, orthogonal things we are mixing here, (1) Arm-ness, (2) Baremetal-ness. Can we split? For the preset its OK, I am talking about things like EXECUTORCH_BUILD_ARM_BAREMETAL the things it guards are not strictly related to Arm.
This will come up when we try to do Arm Cortex-m + Ethos on Zephyr. Passing ARM_BAREMETAL would be confusing at best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, changing it to something like EXECUTORCH_BUILD_ARM_ETHOSU seems reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess depends on the things we want to guard with this build flavor. We need to split this EXEUCTORCH_BUILD_ARM_BAREMETAL into EXECUTORCH_BUILD_ARM_ETHOSU and EXECUTORCH_BUILD_BAREMETAL. I can also see Cortex-M (no NPU) builds and not sure if the ETHOSU is the right suffix either.
- Executorch may be cross compiled for arm-baremetal targets using 'cmake --preset arm-baremetal' - Adds a new flag EXECUTORCH_BUILD_ARM_ETDUMP used in the preset to easy enabling of ET_DUMP. - backend/arm/scripts/build_executorch.sh is updated to use the new preset with same behaviour as before. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218