-
Notifications
You must be signed in to change notification settings - Fork 734
Arm backend: Add arm-baremetal CMake preset #13042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Copyright 2025 Arm Limited and/or its affiliates. | ||
| # | ||
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| set(CMAKE_INSTALL_PREFIX "${CMAKE_BINARY_DIR}") | ||
| set_overridable_option(EXECUTORCH_BUILD_EXECUTOR_RUNNER OFF) | ||
| set_overridable_option(EXECUTORCH_BUILD_ARM_BAREMETAL ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_KERNELS_QUANTIZED ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_CORTEX_M ON) | ||
| set_overridable_option(EXECUTORCH_ENABLE_LOGGING ON) | ||
|
|
||
| define_overridable_option( | ||
| EXECUTORCH_BUILD_ARM_ETDUMP "Build etdump support for Arm" BOOL OFF | ||
| ) | ||
|
|
||
| if("${EXECUTORCH_BUILD_ARM_ETDUMP}") | ||
| set(EXECUTORCH_BUILD_DEVTOOLS ON) | ||
| set(EXECUTORCH_ENABLE_EVENT_TRACER ON) | ||
| set(EXECUTORCH_BUILD_EXTENSION_DATA_LOADER OFF) | ||
| set(FLATCC_ALLOW_WERROR OFF) | ||
| else() | ||
| set(EXECUTORCH_ENABLE_EVENT_TRACER OFF) | ||
| endif() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though this PR is OK, I want to brainstorm here a bit more.
There are two, I think, orthogonal things we are mixing here, (1) Arm-ness, (2) Baremetal-ness. Can we split? For the preset its OK, I am talking about things like
EXECUTORCH_BUILD_ARM_BAREMETALthe things it guards are not strictly related to Arm.This will come up when we try to do Arm Cortex-m + Ethos on Zephyr. Passing ARM_BAREMETAL would be confusing at best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, changing it to something like
EXECUTORCH_BUILD_ARM_ETHOSUseems reasonable to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess depends on the things we want to guard with this build flavor. We need to split this
EXEUCTORCH_BUILD_ARM_BAREMETALintoEXECUTORCH_BUILD_ARM_ETHOSUandEXECUTORCH_BUILD_BAREMETAL. I can also see Cortex-M (no NPU) builds and not sure if theETHOSUis the right suffix either.