Skip to content

forward fix #13129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

forward fix #13129

merged 1 commit into from
Aug 5, 2025

Conversation

@cccclai
Copy link
Contributor

@cccclai cccclai commented Aug 5, 2025 •
edited
Loading

Summary:
Fix the internal test

Reviewed By: psiddh, kirklandsign

Differential Revision: D79597179

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13129

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Unrelated Failure

As of commit 3921676 with merge base 9d86cbe (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D79597179

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Aug 5, 2025
@cccclai @facebook-github-bot
forward fix (pytorch#13129)
560267a 
Summary:

Fix the test
```
buck test 'fbcode//mode/opt' fbcode//gen_ai/genie_projects/bonsai/tests/models:test_models -- --exact 'gen_ai/genie_projects/bonsai/tests/models:test_models - test_executorch_staticllama_models (gen_ai.genie_projects.bonsai.tests.models.test_model_def.TestModelDef)'
```

Reviewed By: psiddh, kirklandsign

Differential Revision: D79597179
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai @facebook-github-bot
forward fix (pytorch#13129)
3921676 
Summary:
Pull Request resolved: pytorch#13129

Fix the test
```
buck test 'fbcode//mode/opt' fbcode//gen_ai/genie_projects/bonsai/tests/models:test_models -- --exact 'gen_ai/genie_projects/bonsai/tests/models:test_models - test_executorch_staticllama_models (gen_ai.genie_projects.bonsai.tests.models.test_model_def.TestModelDef)'
```

Reviewed By: psiddh, kirklandsign

Differential Revision: D79597179
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D79597179

@facebook-github-bot facebook-github-bot merged commit 981119e into pytorch:main Aug 5, 2025
101 of 105 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@cccclai @agrima1304
forward fix
4ab0774 
Differential Revision: D79597179

Pull Request resolved: pytorch#13129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cccclai @facebook-github-bot @kirklandsign