-
Notifications
You must be signed in to change notification settings - Fork 712
ASR JNI bindings #13525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohansjoshi
wants to merge
4
commits into
main
Choose a base branch
from
whisper-jni
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+291
−28
Open
ASR JNI bindings #13525
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
...id/executorch_android/src/main/java/org/pytorch/executorch/extension/audio/ASRModule.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * All rights reserved. | ||
| * | ||
| * This source code is licensed under the BSD-style license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| package org.pytorch.executorch.extension.audio; | ||
| import com.facebook.jni.HybridData; | ||
| import com.facebook.jni.annotations.DoNotStrip; | ||
| import java.io.File; | ||
| import org.pytorch.executorch.ExecuTorchRuntime; | ||
| import org.pytorch.executorch.extension.llm.LlmCallback; | ||
| import org.pytorch.executorch.annotations.Experimental; | ||
|
|
||
| /** | ||
| * ASRModule is a wrapper around the Executorch ASR runners like Whisper runner. | ||
| * | ||
| * <p>Warning: These APIs are experimental and subject to change without notice | ||
| */ | ||
| @Experimental | ||
| public class ASRModule { | ||
|
|
||
| @DoNotStrip private final HybridData mHybridData; | ||
|
|
||
| @DoNotStrip | ||
| private static native HybridData initHybrid( | ||
| String modulePath, String tokenizerPath); | ||
|
|
||
| public ASRModule( | ||
| String modulePath, String tokenizerPath) { | ||
| ExecuTorchRuntime runtime = ExecuTorchRuntime.getRuntime(); | ||
|
|
||
| File modelFile = new File(modulePath); | ||
| if (!modelFile.canRead() || !modelFile.isFile()) { | ||
| throw new RuntimeException("Cannot load model path " + modulePath); | ||
| } | ||
| File tokenizerFile = new File(tokenizerPath); | ||
| if (!tokenizerFile.canRead() || !tokenizerFile.isFile()) { | ||
| throw new RuntimeException("Cannot load tokenizer path " + tokenizerPath); | ||
| } | ||
| mHybridData = initHybrid(modulePath, tokenizerPath); | ||
| } | ||
|
|
||
| public void resetNative() { | ||
| mHybridData.resetNative(); | ||
| } | ||
|
|
||
| @DoNotStrip | ||
| public native int transcribe( | ||
| int seqLen, | ||
| byte[][] inputs, | ||
| LlmCallback callback, | ||
| int n_bins, | ||
| int n_frames); | ||
|
|
||
| /** Force loading the module. Otherwise the model is loaded during first generate(). */ | ||
| @DoNotStrip | ||
| public native int load(); | ||
| } |
2 changes: 2 additions & 0 deletions
2
...executorch_android/src/main/java/org/pytorch/executorch/extension/audio/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /** Extension for audio and ASR related use cases for ExecuTorch Android Java/JNI package. */ | ||
| package org.pytorch.executorch.extension.audio; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should refactor out general purpose ASR logic out of this file and put into asr_runner.h/cpp