TEST ONLY #15227
Draft
TEST ONLY #15227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15227
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit eec63eb with merge base e0dda90 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
kirklandsign
commented
Oct 17, 2025
| .echo = static_cast<bool>(echo), | ||
| .seq_len = seq_len, | ||
| .temperature = temperature_, | ||
| .max_new_tokens = 256, |
Contributor
Author
There was a problem hiding this comment.
Need to set this!
Comment on lines
+114
to
+125
| std::string result = "Image: "; | ||
| if (is_uint8()) { | ||
| result += "uint8_t"; | ||
| } else if (is_float()) { | ||
| result += "float"; | ||
| } else { | ||
| result += "unknown"; | ||
| } | ||
| result += "width: " + std::to_string(width_) + ", "; | ||
| result += "height: " + std::to_string(height_) + ", "; | ||
| result += "channels: " + std::to_string(channels_); | ||
| return result; |
Contributor
There was a problem hiding this comment.
Can you use string stream to avoid copying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.
[PLEASE REMOVE] If this PR closes an issue, please add a
Fixes #<issue-id>line.[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.
Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.