Skip to content

Metal backend: clean up supported_fallback_kernels #15355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Metal backend: clean up supported_fallback_kernels #15355

merged 1 commit into from
Oct 22, 2025

Conversation

@manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented Oct 22, 2025 •
edited
Loading

Removes aoti_torch_mps_addmm_out from the supported_fallback_kernels until an implementation is added.

@manuelcandales
Update
81dffcf 
[ghstack-poisoned]
@manuelcandales
Copy link
Contributor Author

manuelcandales commented Oct 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15355

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Pending, 2 Unrelated Failures

As of commit 81dffcf with merge base 788ef2f (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

manuelcandales added a commit that referenced this pull request Oct 22, 2025
@manuelcandales
Metal backend: clean up supported_fallback_kernels
03eba4a 
ghstack-source-id: 29b25f3
ghstack-comment-id: 3432344614
Pull-Request: #15355
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2025
@manuelcandales manuelcandales added the release notes: none Do not include this in the release notes label Oct 22, 2025
@manuelcandales manuelcandales merged commit befd2d1 into main Oct 22, 2025
155 of 166 checks passed
@manuelcandales manuelcandales deleted the gh/manuelcandales/149/head branch October 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manuelcandales @SS-JIA