Skip to content

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Oct 27, 2025

Initial Render

Screenshot 2025-10-27 at 1 58 14 PM

Click on hamburger

Screenshot 2025-10-27 at 1 58 20 PM

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15396

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 6 Pending, 1 Unrelated Failure

As of commit beca153 with merge base 7ce78c0 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link

@tanvirislam-meta tanvirislam-meta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergennachin The updated banner seems to not have the ET logo and position of the text is different in the mobile version compared to desktop. Is this intentional?

@tanvirislam-meta tanvirislam-meta self-requested a review October 27, 2025 18:41
Copy link

@tanvirislam-meta tanvirislam-meta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments.

@mergennachin
Copy link
Contributor Author

@tanvirislam-meta

Yeah that was intentional. It was too busy in a small screen, so removed one logo. There's already another logo on the left top hand side.

Also moved the text bit so that overlays on top of the solid color.

@mergennachin mergennachin merged commit 8bdaf4e into main Oct 27, 2025
138 of 151 checks passed
@mergennachin mergennachin deleted the fix_mobile branch October 27, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants