Skip to content

Revert ARM PRs fdfeaa4..4675292 #15397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Revert ARM PRs fdfeaa4..4675292 #15397

wants to merge 19 commits into from

Conversation

@GregoryComer
Copy link
Member

Summary

Temporarily reverting #15356 and stacked Arm backend PRs due to a buck build breakage blocking code sync. Will re-land when resolved. CC @digantdesai

@GregoryComer
Revert "Arm backend: Merge RetraceFoldedDtypesPass into FoldAndAnnota…
4da1550 
…teQParam… (pytorch#15377)"

This reverts commit 4675292.
@GregoryComer
Revert "Arm backend: Serialize controlflow submodules. (pytorch#15381)"
5b1a947 
This reverts commit a4e7475.
@GregoryComer
Revert "Arm backend: Remove pyre-unsafe from remaining files (pytorch…
4250b49 
…#15391)"

This reverts commit 5426918.
@GregoryComer
Revert "Arm backend: Move rescales from ADD & SUB visitors to pass (p…
d975528 
…ytorch#15378)"

This reverts commit 4efd79c.
@GregoryComer
Revert "Arm backend: Remove pyre-unsafe from operators/ (pytorch#15376)"
5c59fa0 
This reverts commit cf407fc.
@GregoryComer
Revert "Arm backend: Align operator_validation_utils docstrings with …
efae4a8 
…backend (pytorch#15369)"

This reverts commit ce6b6e5.
@GregoryComer
Revert "Arm backend: Deprecate internal models using aot_arm_compiler (…
3a50a0b 
…pytorch#15302)"

This reverts commit cea66e3.
@GregoryComer
Revert "Arm backend: Remove pyre-unsafe from quantizer/ & backends/arm (
e83e676 
pytorch#15374)"

This reverts commit 80b4a84.
@GregoryComer
Revert "Arm backend: Add docstrings for operator_support/embedding_su…
ddfa961 
…pport.py (pytorch#15373)"

This reverts commit ef04360.
@GregoryComer
Revert "Arm backend: Merge passes that replace scalars (pytorch#15298)"
a4c3cd7 
This reverts commit de56c81.
@GregoryComer
Revert "Arm backend: Use reshape instead of view before edge (pytorch…
16f7f7a 
…#15269)"

This reverts commit 69f79b9.
@GregoryComer
Revert "Arm backend: Fix arg-type MyPy errors (pytorch#15367)"
a71332d 
This reverts commit c66078c.
@GregoryComer
Revert "Arm backend: Remove pyre-unsafe from _passes/ (pytorch#15351)"
e204ea6 
This reverts commit 4b42bea.
@GregoryComer
Revert "Arm backend: Remove pyre-unsafe from tosa/, vgf/ and ethosu/ (p…
eb2c876 
…ytorch#15352)"

This reverts commit eff4024.
@GregoryComer
Revert "Arm backend: Move rescales from SUM visitor to pass (pytorch#…
8167327 
…15299)"

This reverts commit c4cd274.
@GregoryComer
Revert "Arm backend: Tag control flow submodules in partitioner (pyto…
008a014 
…rch#15364)"

This reverts commit b24c39a.
@GregoryComer
Revert "Arm backend: support mean.default (pytorch#15363)"
a3ff326 
This reverts commit 9075855.
@GregoryComer
Revert "Arm backend: Support per-channel in TOSA.RESCALE (pytorch#15267…
53bb98b 
…)"

This reverts commit f7ca57e.
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15397

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 4 Unrelated Failures

As of commit 36f25ce with merge base cd6f2e2 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ci-no-td label Oct 27, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2025
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Oct 27, 2025
@digantdesai
Copy link
Contributor

Did you miss the main PR with the issue?

@GregoryComer
Copy link
Member Author

GregoryComer commented Oct 27, 2025 •
edited
Loading

Did you miss the main PR with the issue?

Oops, good catch. Fixed. Git hash range excluding the first got me.

@digantdesai digantdesai requested a review from ArmRyan October 27, 2025 18:42
@digantdesai
Copy link
Contributor

Thanks @GregoryComer. Added Arm folks in the review as FYI.

digantdesai
digantdesai approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping to unblock the internal stack landing

@GregoryComer
Copy link
Member Author

GregoryComer commented Oct 27, 2025 •
edited
Loading

Holding off on merging this as Digant is trying to resolve the Meta build issue. I'll update by EOD.

Edit: Update, still working on trying to forward fix. Will evaluate in the morning.

@GregoryComer GregoryComer mentioned this pull request Oct 27, 2025
Merged
@zingo
Copy link
Collaborator

zingo commented Oct 27, 2025

Thanks for the help @GregoryComer 🙏
Lets see if its needed.

GregoryComer added a commit that referenced this pull request Oct 27, 2025
@GregoryComer
Bump linux unittest runner to linux.2xlarge.memory (#15400)
c0c3338 
### Summary
Unittest jobs are dying since
#15180. I'm not entirely sure
why the jobs passed on the PR, but they are failing consistently since
on trunk. Testing a runner size bump (2xlarge -> 2xlarge.memory) to see
if that resolves it.

Example logs (from another
[PR](#15397)). Note that the
exit code (137 / SIGKILL) likely means OOM kill.
```
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
...
Process completed with exit code 137.
```
@zingo
Copy link
Collaborator

zingo commented Oct 29, 2025 •
edited
Loading

@GregoryComer @digantdesai do we want to merge this to unblock?

@GregoryComer
Copy link
Member Author

@GregoryComer @digantdesai do we want to merge this to unblock?

It looks like Digant got the internal build unblocked, so I'll close this. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@zingo zingo Awaiting requested review from zingo

@robell robell Awaiting requested review from robell

@Erik-Lundell Erik-Lundell Awaiting requested review from Erik-Lundell

@martinlsm martinlsm Awaiting requested review from martinlsm

@ArmRyan ArmRyan Awaiting requested review from ArmRyan

Assignees

No one assigned

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GregoryComer @digantdesai @zingo