Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Oct 27, 2025

Summary

Trying to fix failing HF CI jobs. Looks like our transformers version requires huggingface_hub<1.0, but we're installing the latest 1.0 version which just released today. Until we bump transformers, I'll just pin our install of huggingface_hub to below 1.0.

Note that we don't pin the transformers version the same way for pip install, so this should be a ci only issue (and hence ci only fix).

Here's an example job failure:

transformers 4.56.1 requires huggingface-hub<1.0,>=0.34.0, but you have huggingface-hub 1.0.0 which is incompatible.
...
/exec: line 13: huggingface-cli: command not found

(from https://github.com/pytorch/executorch/actions/runs/18851188516/job/53787937311)

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15399

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 3 Pending, 3 Unrelated Failures

As of commit e774959 with merge base cd6f2e2 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer GregoryComer marked this pull request as ready for review October 27, 2025 19:52
@GregoryComer
Copy link
Member Author

GregoryComer commented Oct 27, 2025

Note that unit test ci failures are preexisting (getting to this next). Model test failure is a flake and I can't rerun until the whole pull job finishes. I'd like to land this one the relevant ci jobs pass to unbreak ci.

@GregoryComer GregoryComer merged commit 57f0dfd into main Oct 27, 2025
292 of 308 checks passed
@GregoryComer GregoryComer deleted the pin-hf-hub branch October 27, 2025 20:19
GregoryComer added a commit that referenced this pull request Oct 27, 2025
### Summary
We need to pin huggingface_hub in CI to avoid an incompatibility with
our pinned version of transformers. See
#15399 for more context - I
missed a few places on trunk jobs. Cleaning these up here.

### Test Plan
Running with ciflow/trunk. I verified that the
test-huggingface-transformers-macos / * and gemma3-4b macos jobs pass on
this PR. They are failing on trunk (see
https://hud.pytorch.org/pytorch/executorch/commit/4c30da308ee811bdfa44fd4bea3bc439bfd303d4
for an example).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants