Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Oct 27, 2025

Summary

Similar to #15401, skip test-samsung-models-linux on forked PRs as it requires secrets and thus fails. This should reduce false-negatives / noise on contributor PRs.

Example failure (from https://github.com/pytorch/executorch/actions/runs/18856230366/job/53804732612):

Failed to extract download URL
{"success":false,"data":null,"msg":"API key is required","page":0,"total":0}
exit 1

Test Plan

Verified that test-samsung-models-linux is skipped on this PR.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15402

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit fe417f6 with merge base 57f0dfd (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2025
@GregoryComer GregoryComer requested a review from SS-JIA October 27, 2025 22:01
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Oct 27, 2025
@GregoryComer GregoryComer marked this pull request as ready for review October 27, 2025 22:03
@GregoryComer GregoryComer merged commit 94def70 into pytorch:main Oct 28, 2025
229 of 242 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants