Skip to content

[aoti-et] Tag unused lifted constant placeholders #15439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

[aoti-et] Tag unused lifted constant placeholders #15439

merged 2 commits into from
Oct 29, 2025

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Oct 29, 2025

For lifted constants, if they are not being used, they won't be tagged by tag_constant_data() API. We have to manually tag them in cuda partitioner.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15439

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 22 Pending

As of commit 821bb70 with merge base 5914f8f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@larryliu0820
[aoti-et] Tag unused lifted constant placeholders
eb8c2bc 
For lifted constants, if they are not being used, they won't be tagged
by `tag_constant_data()` API. We have to manually tag them in cuda
partitioner.
@larryliu0820 larryliu0820 merged commit efc2be7 into main Oct 29, 2025
151 checks passed
@larryliu0820 larryliu0820 deleted the tag_constants branch October 29, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gasoonjia Gasoonjia Gasoonjia approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larryliu0820 @Gasoonjia