Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Oct 30, 2025

Stack from ghstack (oldest at bottom):

Should this be a public API? May be relatively easy for user to impl with the existing deserialize functionality.

Differential Revision: D83510300

Should this be a public API? May be relatively easy for user to impl with the existing deserialize functionality.

Differential Revision: [D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Oct 30, 2025
Should this be a public API? May be relatively easy for user to impl with the existing deserialize functionality.

Differential Revision: [D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)

ghstack-source-id: 312879155
Pull Request resolved: #15469
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15469

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4596575 with merge base c85ece4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Should this be a public API? May be relatively easy for user to impl with the existing deserialize functionality.

Differential Revision: [D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Oct 30, 2025
Pull Request resolved: #15469

Relatively easy for user to impl with the existing deserialize functionality, but think it's good to have something explicit too.

Differential Revision: [D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)
ghstack-source-id: 319841977
Should this be a public API? May be relatively easy for user to impl with the existing deserialize functionality.

Differential Revision: [D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Oct 30, 2025
Pull Request resolved: #15469

Relatively easy for user to impl with the existing deserialize functionality, but think it's good to have something explicit too.
ghstack-source-id: 319841977

Differential Revision: [D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)
Should this be a public API? May be relatively easy for user to impl with the existing deserialize functionality.

Differential Revision: [D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Oct 30, 2025
Pull Request resolved: #15469

Relatively easy for user to impl with the existing deserialize functionality, but think it's good to have something explicit too.
ghstack-source-id: 319896032

Differential Revision: [D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)
@meta-codesync meta-codesync bot merged commit bc6499c into gh/lucylq/122/base Oct 31, 2025
239 of 241 checks passed
@meta-codesync meta-codesync bot deleted the gh/lucylq/122/head branch October 31, 2025 00:20
lucylq added a commit that referenced this pull request Oct 31, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #15469 by
@lucylq
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/122/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/122/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/122/orig
Differential Revision:
[D83510300](https://our.internmc.facebook.com/intern/diff/D83510300/)
@diff-train-skip-merge

Co-authored-by: lucylq <lfq@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants