Skip to content

Conversation

@psiddh
Copy link
Contributor

@psiddh psiddh commented Oct 31, 2025

Summary: The test should expect -18 because that's the mathematically correct result when you include the ÷ 2^20 (SHIFT_INT8) factor that ARM chips need for their quantization.

Reviewed By: GregoryComer

Differential Revision: D85986326

…value (2^20)

Summary: The test should expect -18 because that's the mathematically correct result when you include the ÷ 2^20 (SHIFT_INT8) factor that ARM chips need for their quantization.

Reviewed By: GregoryComer

Differential Revision: D85986326
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15503

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4f78ccd with merge base bbc0967 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 31, 2025

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85986326.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit c230e94 into pytorch:main Oct 31, 2025
147 of 157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants