Skip to content

Conversation

@psiddh
Copy link
Contributor

@psiddh psiddh commented Nov 3, 2025

…est failures

Added skip functionality (because buck based targets do not seem to comply with xfail marker) to the test parametrize framework to handle known failing tests in ARM backend 16A8W quantization. The model_linear_rank4_zeros, model_linear_rank4_negative_ones, and model_linear_rank4_negative_large_rand test cases are now skipped due to bias quantization accuracy issues tracked in MLETORCH-1452. This prevents buck based CI from blocking while maintaining visibility of the known issues through proper test annotations.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15514

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit a03e6cf with merge base a11d555 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@psiddh psiddh requested a review from GregoryComer November 3, 2025 06:23
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh psiddh marked this pull request as ready for review November 3, 2025 06:25
@psiddh psiddh requested a review from digantdesai as a code owner November 3, 2025 06:25
@psiddh psiddh requested review from AdrianLundell and zingo November 3, 2025 06:25
…est failures

Added skip functionality (because buck based targets do not seem to comply with xfail marker) to the test parametrize framework to handle known failing tests in ARM backend 16A8W quantization. The model_linear_rank4_zeros, model_linear_rank4_negative_ones, and model_linear_rank4_negative_large_rand test cases are now skipped due to bias quantization accuracy issues tracked in MLETORCH-1452. This prevents buck based CI from blocking while maintaining visibility of the known issues through proper test annotations.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@AdrianLundell
Copy link
Collaborator

Seems a bit strange to me that xfails would not work for a particular test case, or am I misunderstanding something? Also, if this is a temporary fix I would prefer if you could break out the odd test cases into a new test and skip that rather than modifying the testing infrastructure.

@psiddh
Copy link
Contributor Author

psiddh commented Nov 3, 2025

Seems a bit strange to me that xfails would not work for a particular test case, or am I misunderstanding something? Also, if this is a temporary fix I would prefer if you could break out the odd test cases into a new test and skip that rather than modifying the testing infrastructure.

Not sure if this is modifying any testing infra. It is only adding 'skip' marker to parameter impl as fwd fix. Only for the tests that are failing on internal CI (buck based), added the skip marker for now so that we don't have to backout a PR , satisfying both OSS CI & internal buck based CI. We can discuss a cleaner fix if you have better ideas / suggestions but we need to keep the CI train for now moving as it has been stalled since Friday due to these issues

@psiddh psiddh merged commit 4a75896 into main Nov 3, 2025
151 checks passed
@psiddh psiddh deleted the skip_marker branch November 3, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants