-
Notifications
You must be signed in to change notification settings - Fork 714
Arm backend: Initial support of conditional operator #15549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As mentioned in pytorch#15381, TOSA tensors need unique naming, which gets tricky with submodules. It is handled in the TosaArg object, and therefore node visitors need to use output.name rather than node.name when creating new tensors. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I7a943deda0888c1de8796dd573e8befda3f074b2
- Add partition check to make sure that the submodules with the if/else codepaths are fully delegated. - Fix some partitioning issues with submodule nodes, since they point to a submodule rather than a tensor they dont have a fake tensor. - Add node visitor. - Add tests. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I00dbfdedb04c686ce04b4fb1d682816038b7e1bf
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15549
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (7 Unrelated Failures)As of commit 7198aa0 with merge base 4ea9ddf ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi again @SS-JIA here is a lager patch touching many file. Sorry we got so many in a row right now, it's usually calmer :) |
|
@SS-JIA we think this should be buck2 build safe as the new cond op should be handled by the |
SS-JIA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be okay!
|
Failed tests seems unrelated |
Arm backend: Use output.name in node visitors
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai