-
Notifications
You must be signed in to change notification settings - Fork 712
[Executorch][llm] Fix flakyness of quantized sdpa test #15653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/kimishpatel/204/base
Are you sure you want to change the base?
Conversation
Without this fix when running diabled tets it fails with OMP: Error #131: Thread identifier invalid Differential Revision: [D86447540](https://our.internmc.facebook.com/intern/diff/D86447540/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15653
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit 4d79df5 with merge base 15a0fcd ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
| self.q_shape = None | ||
| self.kv_shape = None | ||
| self.is_seq_at_dim_2 = True | ||
| # For some reason 4 threads doesnt work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a concern with users choose a thread count that doesn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is specifically related to OMP which I am definitely a bit surprised why it occurs here. This hasnt been observed on-device
Stack from ghstack (oldest at bottom):
Without this fix when running diabled tets it fails with
OMP: Error #131: Thread identifier invalid
Differential Revision: D86447540