Skip to content

Only block when building with MSVC #15719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobSzwejbka merged 2 commits into from
Nov 10, 2025
Merged

Only block when building with MSVC #15719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d110d2
only block when building with MSVC
JacobSzwejbka Nov 10, 2025
b3af9b0
try 2
JacobSzwejbka Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tools/cmake/preset/llm.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,21 @@ set_overridable_option(EXECUTORCH_BUILD_EXTENSION_TENSOR ON)
set_overridable_option(EXECUTORCH_BUILD_KERNELS_OPTIMIZED ON)
set_overridable_option(EXECUTORCH_BUILD_XNNPACK ON)

# Turn on the quantized and LLM kernels unless on windows cuda build which
# currently doesn't support this due to using msvc.
if(NOT (EXECUTORCH_BUILD_CUDA AND (CMAKE_SYSTEM_NAME STREQUAL "Windows"
OR CMAKE_SYSTEM_NAME STREQUAL "WIN32"))
# Turn on the quantized and LLM kernels unless on Windows with MSVC build since
# they don't currently compile.
if(NOT ((CMAKE_SYSTEM_NAME STREQUAL "Windows" OR CMAKE_SYSTEM_NAME STREQUAL
"WIN32") AND MSVC)
)
set_overridable_option(EXECUTORCH_BUILD_KERNELS_QUANTIZED ON)
set_overridable_option(EXECUTORCH_BUILD_KERNELS_LLM ON)
else()
if(NOT EXECUTORCH_BUILD_CUDA)
message(
WARNING
"The llm custom kernels and the quantized kernels will not be built when using MSVC on Windows. "
"If you need them (since you appear to be building for CPU) try building with -T ClangCL"
)
endif()
endif()

if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
Expand Down
Loading