Skip to content

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Nov 11, 2025

Stack from ghstack (oldest at bottom):

Title says it all! forward fix of D86741047, which caused build failures from introducing a new file.

Differential Revision: D86786510

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Title says it all! forward fix of D86741047, which caused build failures from introducing a new file.

Differential Revision: [D86786510](https://our.internmc.facebook.com/intern/diff/D86786510/)

[ghstack-poisoned]
@SS-JIA SS-JIA requested a review from digantdesai as a code owner November 11, 2025 19:38
SS-JIA pushed a commit that referenced this pull request Nov 11, 2025
Title says it all! forward fix of D86741047, which caused build failures from introducing a new file.

Differential Revision: [D86786510](https://our.internmc.facebook.com/intern/diff/D86786510/)

ghstack-source-id: 322481871
Pull Request resolved: #15759
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15759

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Unrelated Failure

As of commit 1616903 with merge base failed to retrieve merge base, please contact dev infra:

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2025
@zingo zingo added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm module: arm Issues related to arm backend release notes: none Do not include this in the release notes labels Nov 12, 2025
@SS-JIA SS-JIA closed this Nov 12, 2025
@zingo
Copy link
Collaborator

zingo commented Nov 13, 2025

Why not merge this anyway, seems a good idea to use a glob here

@SS-JIA
Copy link
Contributor Author

SS-JIA commented Nov 14, 2025

@zingo closed since the original PR was reverted. Figured it's easier to just add it to the re-land PR: #15778

@SS-JIA
Copy link
Contributor Author

SS-JIA commented Nov 14, 2025

oh, actually I just realized that the changes are independent :p I suppose we could have landed it separately 😅

@zingo zingo reopened this Nov 14, 2025
@zingo zingo closed this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants