Arm backend: Propagate node info from quantizer to backend (re-uploaded) #15778
+336
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15778
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c557356 with merge base 8c48a76 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
oscarandersson8218
force-pushed
the
node_quant_metadata_serializable
branch
from
3fa6e64 to
e308913
Compare
Contributor
|
@oscarandersson8218 still failing due to Mind adding the buck file change from #15759? |
Use the Node meta 'custom' field to propagate information from quantizer to partitioner using a new ArmAnnotationInfo data class. This allows us to track quantized node reliably which is useful in order to track which nodes should 'fold' it's quantization parameter and which should be kept in fp when mixing integer and float in a sub-graph. Co-authored-by: Per Åstrand <per.astrand@arm.com> Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I398bf52e14d58fce56aa46ace74e45f45050c81b
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I84aa43f880e0ea7bbefb30bf7f31fc0e3b362e5a
oscarandersson8218
force-pushed
the
node_quant_metadata_serializable
branch
from
e308913 to
c557356
Compare
Collaborator
|
Hi @SS-JIA as this and the internal Meta PR is different now this needs a re-import to get OK to merge e.g. we now get: Meta Internal-Only Changes Check — The Diff and Pull Request are not in sync! Thanks for your help with this PR (and other) |
zingo
approved these changes
Nov 14, 2025
Contributor
|
Tests look good now - feel free to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Node meta 'custom' field to propagate information from quantizer to partitioner using a new ArmAnnotationInfo data class. This allows us to track quantized node reliably which is useful in order to track which nodes should 'fold' it's quantization parameter and which should be kept in fp when mixing integer and float in a sub-graph.
cc @freddan80 @per @zingo @digantdesai