Skip to content

Conversation

@mcremon-meta
Copy link
Contributor

Summary:
We will then replace them with the native aten versions.

  • Replace cadence.convolution with cadence.conv1d and cadence.conv2d. Add cadence.conv3d.
  • Removes the channel_last arg

Differential Revision: D86473542

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15762

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 2 Unrelated Failures

As of commit b5df934 with merge base 0c0cee5 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 11, 2025

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86473542.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

mcremon-meta added a commit that referenced this pull request Nov 12, 2025
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Differential Revision: D86473542
mcremon-meta added a commit that referenced this pull request Nov 14, 2025
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Reviewed By: ethansfng

Differential Revision: D86473542
mcremon-meta added a commit that referenced this pull request Nov 14, 2025
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Reviewed By: ethansfng

Differential Revision: D86473542
mcremon-meta added a commit that referenced this pull request Nov 14, 2025
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Reviewed By: ethansfng

Differential Revision: D86473542
mcremon-meta added a commit that referenced this pull request Nov 14, 2025
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Reviewed By: ethansfng

Differential Revision: D86473542
mcremon-meta added a commit that referenced this pull request Nov 15, 2025
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Reviewed By: ethansfng

Differential Revision: D86473542
mcremon-meta added a commit that referenced this pull request Nov 15, 2025
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Reviewed By: ethansfng

Differential Revision: D86473542
mcremon-meta added a commit that referenced this pull request Nov 15, 2025
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Reviewed By: ethansfng

Differential Revision: D86473542
Summary:
Pull Request resolved: #15762

We will then replace them with the native aten versions.
- Replace `cadence.convolution` with `cadence.conv1d` and `cadence.conv2d`. Add `cadence.conv3d`.
- Removes the channel_last arg

Reviewed By: ethansfng

Differential Revision: D86473542
@meta-codesync meta-codesync bot merged commit b1e3e28 into main Nov 16, 2025
164 of 174 checks passed
@meta-codesync meta-codesync bot deleted the export-D86473542 branch November 16, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants