-
Notifications
You must be signed in to change notification settings - Fork 722
Introduce PTEFile class #15800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/lucylq/125/base
Are you sure you want to change the base?
Introduce PTEFile class #15800
Conversation
PTEFile class holds the components of a PTE file: the program, mutable constants and named data. Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept. Now, segment data is included in the PTEFile class. Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15800
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New Failures, 2 Unrelated FailuresAs of commit c6d72f5 with merge base 7600df8 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
PTEFile class holds the components of a PTE file: the program, mutable constants and named data. Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept. Now, segment data is included in the PTEFile class. Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/) [ghstack-poisoned]
zingo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.
@zingo thanks for the suggestion - could you comment a bit more on what you're looking for? |
Im thinking the it might be god to have if you made tools parsing the different files. As Im not writing those kind of tools right now Im not sure its fully applicable but I feel the bpte are sometimes forgotten or need special handling. |
PTEFile class holds the components of a PTE file: the program, mutable constants and named data. Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept. Now, segment data is included in the PTEFile class. Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/) [ghstack-poisoned]
Pull Request resolved: #15800 PTEFile class holds the components of a PTE file: the program, mutable constants and named data. Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept. Now, segment data is included in the PTEFile class. ghstack-source-id: 322859321 @exported-using-ghexport Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)
PTEFile class holds the components of a PTE file: the program, mutable constants and named data. Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept. Now, segment data is included in the PTEFile class. Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/) [ghstack-poisoned]
PTEFile class holds the components of a PTE file: the program, mutable constants and named data. Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept. Now, segment data is included in the PTEFile class. Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/) [ghstack-poisoned]
Stack from ghstack (oldest at bottom):
PTEFile class holds the components of a PTE file: the program, mutable constants and named data.
Currently, the
programdefinition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into theprogramconcept.Now, segment data is included in the PTEFile class.
Differential Revision: D86814175