Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Nov 13, 2025

Stack from ghstack (oldest at bottom):

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the program definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the program concept.

Now, segment data is included in the PTEFile class.

Differential Revision: D86814175

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15800

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 2 Unrelated Failures

As of commit c6d72f5 with merge base 7600df8 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
Copy link
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.

@lucylq
Copy link
Contributor Author

lucylq commented Nov 14, 2025

It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.

@zingo thanks for the suggestion - could you comment a bit more on what you're looking for?

@zingo
Copy link
Collaborator

zingo commented Nov 14, 2025

It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.

@zingo thanks for the suggestion - could you comment a bit more on what you're looking for?

Im thinking the it might be god to have if you made tools parsing the different files. As Im not writing those kind of tools right now Im not sure its fully applicable but I feel the bpte are sometimes forgotten or need special handling.

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Nov 14, 2025
Pull Request resolved: #15800

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.
ghstack-source-id: 322859321
@exported-using-ghexport

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)
PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants