Arm backend: Fix ubsan warning in example runner #15846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perheld
added
ciflow/trunk
module: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15846
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 844e029 with merge base 3bbe173 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
perheld
force-pushed
the
ph-sanitizers-fix-runner
branch
from
4296658 to
91bd723
Compare
zingo
approved these changes
Nov 17, 2025
Collaborator
Author
|
Memory allocator test fails so I need to update that. Hold for a second commit in this PR. |
perheld
force-pushed
the
ph-sanitizers-fix-runner
branch
from
91bd723 to
accf50d
Compare
Avoid dangerous pointer arithmetic by making sure EValue lands at its natural alignment (8 bytes on this target). Signed-off-by: per.held@arm.com Change-Id: I3efee39f5c36ea76e08373fccc5ff10c01cbc588
Since memory allocation is aligned it takes more space. Signed-off-by: per.held@arm.com Change-Id: Ib1506d5f3a4383dba05f10c0082c31d37a8af80e
perheld
force-pushed
the
ph-sanitizers-fix-runner
branch
from
accf50d to
844e029
Compare
Collaborator
Author
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid dangerous pointer arithmetic by making sure EValue lands at its natural alignment (8 bytes on this target).
Signed-off-by: per.held@arm.com
Change-Id: I3efee39f5c36ea76e08373fccc5ff10c01cbc588