Skip to content

Conversation

Copy link

Copilot AI commented Nov 17, 2025

Summary

Addresses feedback from #15566 (review comment) to remove duplicate .nav-links selector in website/style.css.

Changes:

  • Removed redundant .nav-links selector (lines 1038-1040) that only set display: none
  • Kept complete selector (lines 1038-1052) with all mobile menu styles including display: none

Before:

.nav-links {
    display: none;
}
.nav-links {
    display: none;
    flex-direction: column;
    background: rgba(48,48,48,0.98);
    /* ... rest of mobile menu styles */
}

After:

.nav-links {
    display: none;
    flex-direction: column;
    background: rgba(48,48,48,0.98);
    /* ... rest of mobile menu styles */
}

Mobile navigation

Test plan

Validated CSS syntax (balanced braces) and tested mobile navigation rendering at 375px viewport.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

tanvirislam-meta and others added 3 commits November 4, 2025 09:56
Fixed issues with reactive sizing of banners and updated nav menu for mobile/reactive rendering.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15850

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 68 Pending

As of commit 046e167 with merge base be8b775 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Nov 17, 2025

Hi @Copilot!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copilot AI changed the title [WIP] Address feedback on reactive rendering fixes in webpage PR Remove duplicate .nav-links CSS selector Nov 17, 2025
Copilot AI requested a review from mergennachin November 17, 2025 16:08
Base automatically changed from tanvir-dev to main November 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants