-
Notifications
You must be signed in to change notification settings - Fork 743
Arm backend: Add support for int32 clamp #15977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Add support for int32 clamp #15977
Conversation
Tosa does not support int32 dtype for clamp operator so instead we need to use Min/Max to implement clamp. Signed-off-by: Ryan O'Shea <ryan.oshea3@arm.com> Change-Id: Iea442901b2227610ebb5e5a0f1bca8d236e70d9d
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15977
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit caf8938 with merge base 2ed6d6a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
oscarandersson8218
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be done in a pass instead.
Signed-off-by: Ryan O'Shea <ryan.oshea3@arm.com> Change-Id: I6678a4da16854c03c2f820945007db901adbe923
Done |
oscarandersson8218
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failures seem unrelated.
Tosa does not support int32 dtype for clamp operator
so instead we need to use Min/Max to implement clamp.
Change-Id: Iea442901b2227610ebb5e5a0f1bca8d236e70d9d
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai