Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

Summary:
Currently we used static sigature for the monkey patch functioned, which is fragile and will break if the original function's input signature changed.

This diff hides all irrevalant inputs under *args and **kwargs to make the signature auto-synced and robust.

Differential Revision: D88114494

Summary:
Currently we used static sigature for the monkey patch functioned, which is fragile and will break if the original function's input signature changed.

This diff hides all irrevalant inputs under *args and **kwargs to make the signature auto-synced and robust.

Differential Revision: D88114494
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16031

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit ad66e6a with merge base 1864fb0 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 2, 2025

@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88114494.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit a93f59e into main Dec 2, 2025
167 of 173 checks passed
@meta-codesync meta-codesync bot deleted the export-D88114494 branch December 2, 2025 07:29
AdrianLundell pushed a commit to AdrianLundell/executorch that referenced this pull request Dec 2, 2025
Differential Revision: D88114494

Pull Request resolved: pytorch#16031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants