-
Notifications
You must be signed in to change notification settings - Fork 754
reorganize VOLK_IMPLEMENTATION usage #16055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16055
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 9d42fe0 with merge base 4014597 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@SamGondelman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87851728. |
This PR needs a
|
Summary: when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients. this makes combining multiple volk-dependent libraries easier Reviewed By: corporateshark Differential Revision: D87851728
76d86ad to
f455aa4
Compare
Summary: when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients. this makes combining multiple volk-dependent libraries easier Reviewed By: corporateshark Differential Revision: D87851728
f455aa4 to
648d7dc
Compare
Summary: when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients. this makes combining multiple volk-dependent libraries easier Reviewed By: corporateshark Differential Revision: D87851728
Summary: when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients. this makes combining multiple volk-dependent libraries easier Reviewed By: corporateshark, SS-JIA Differential Revision: D87851728
648d7dc to
9d42fe0
Compare
Summary: when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients. this makes combining multiple volk-dependent libraries easier
Differential Revision: D87851728