Skip to content

Conversation

@SamGondelman
Copy link
Contributor

Summary: when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients. this makes combining multiple volk-dependent libraries easier

Differential Revision: D87851728

@SamGondelman SamGondelman requested a review from SS-JIA as a code owner December 2, 2025 22:12
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16055

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 9d42fe0 with merge base 4014597 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 2, 2025

@SamGondelman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87851728.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

SamGondelman added a commit to SamGondelman/executorch that referenced this pull request Dec 3, 2025
Summary:

when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients.  this makes combining multiple volk-dependent libraries easier

Reviewed By: corporateshark

Differential Revision: D87851728
@SamGondelman SamGondelman force-pushed the export-D87851728 branch 2 times, most recently from 76d86ad to f455aa4 Compare December 3, 2025 05:17
SamGondelman added a commit to SamGondelman/executorch that referenced this pull request Dec 3, 2025
Summary:

when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients.  this makes combining multiple volk-dependent libraries easier

Reviewed By: corporateshark

Differential Revision: D87851728
SamGondelman added a commit to SamGondelman/executorch that referenced this pull request Dec 4, 2025
Summary:

when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients.  this makes combining multiple volk-dependent libraries easier

Reviewed By: corporateshark

Differential Revision: D87851728
Summary:

when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients.  this makes combining multiple volk-dependent libraries easier

Reviewed By: corporateshark, SS-JIA

Differential Revision: D87851728
@meta-codesync meta-codesync bot merged commit 41292e5 into pytorch:main Dec 8, 2025
139 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants