[ET-VK] Enable and test texture IO for quantized convolution ops #16082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2025 07:37
Address the benchmark binaries reporting worse performance than one month ago. The regression was not a "real" regression but due to some changes in the benchmark binaries that were made during debugging but were not reverted during landing: 1. Only running 1 benchmark iteration without any warmup iterations 2. The quantize/dequantize shaders would normally be excluded for the overall execution time / FLOPS calculation, but the name of these shaders was recently changed and the logic that filtered these shaders when reporting time was not updated accordingly. Also includes a small fix to the input data loading logic. Differential Revision: [D88381899](https://our.internmc.facebook.com/intern/diff/D88381899/) [ghstack-poisoned]
Title says it all! Using texture3d as the input/output storage type may allow for additional optimizations re: bounds checking. Differential Revision: [D88395020](https://our.internmc.facebook.com/intern/diff/D88395020/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16082
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 107 Pending, 2 Unrelated FailuresAs of commit 98ea762 with merge base 2d1f181 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
pushed a commit
that referenced
this pull request
Dec 4, 2025
Title says it all! Using texture3d as the input/output storage type may allow for additional optimizations re: bounds checking. Differential Revision: [D88395020](https://our.internmc.facebook.com/intern/diff/D88395020/) ghstack-source-id: 327133398 Pull Request resolved: #16082
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
manuelcandales
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Title says it all!
Using texture3d as the input/output storage type may allow for additional optimizations re: bounds checking.
Differential Revision: D88395020