Skip to content

bump arm cortex size test #16134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucylq merged 1 commit into from
Dec 8, 2025
Merged

bump arm cortex size test #16134

lucylq merged 1 commit into from
Dec 8, 2025

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Dec 8, 2025

after 42e3222

Fail 135776 > 135768

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16134

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2025
@lucylq lucylq marked this pull request as ready for review December 8, 2025 19:48
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq changed the title bump arm cortext size bump arm cortex size test Dec 8, 2025
@zingo
Copy link
Collaborator

zingo commented Dec 8, 2025

Thanks for the help we had not got around to look into a PR yet.

zingo
zingo approved these changes Dec 8, 2025
View reviewed changes
.github/workflows/trunk.yml Outdated
setup_script_args="--target-toolchain zephyr"
toolchain_prefix=arm-zephyr-eabi-
threshold="135768" # 136 KiB
threshold="135776" # 136 KiB
Copy link
Collaborator

@zingo zingo Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We might want to let this have some smal buffer/slack.

@zingo zingo added the module: arm Issues related to arm backend label Dec 8, 2025
@lucylq lucylq force-pushed the lfq.bump-arm-cortex-size branch from 38c4c28 to 74a15d7 Compare December 8, 2025 21:03
@lucylq lucylq merged commit 27e8556 into main Dec 8, 2025
294 of 297 checks passed
@lucylq lucylq deleted the lfq.bump-arm-cortex-size branch December 8, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

@kirklandsign kirklandsign kirklandsign approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucylq @zingo @kirklandsign