NXP backend: Add dim order support to NeutronBackend. #16146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16146
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 8 Pending, 1 Unrelated FailureAs of commit e67d1f2 with merge base d8c9c74 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
MartinPavella
added
module: nxp
MartinPavella
force-pushed
the
nxg01483/feature/EIEX-630-prohibit-unexpected-dim-orders-in-the-neutronruntime
branch
from
cb9caa3 to
304fd74
Compare
meta-cla
bot
added
the
CLA Signed
MartinPavella
requested review from
jirioc and
robert-kalmar
and removed request for
robert-kalmar
MartinPavella
force-pushed
the
nxg01483/feature/EIEX-630-prohibit-unexpected-dim-orders-in-the-neutronruntime
branch
from
304fd74 to
a069bba
Compare
jirioc
reviewed
Dec 9, 2025
MartinPavella
force-pushed
the
nxg01483/feature/EIEX-630-prohibit-unexpected-dim-orders-in-the-neutronruntime
branch
from
a069bba to
5971669
Compare
robert-kalmar
approved these changes
Dec 12, 2025
| // The input matches the ExecuTorch format, so no transposition is | ||
| // needed. | ||
|
|
||
| if (!is_contiguous_dim_order(dim_order, arg.dim())) { |
MartinPavella
force-pushed
the
nxg01483/feature/EIEX-630-prohibit-unexpected-dim-orders-in-the-neutronruntime
branch
from
5971669 to
e67d1f2
Compare
xingguo01
pushed a commit
to xingguo01/executorch
that referenced
this pull request
Dec 18, 2025
### Summary This PR enables the utilization of channels last dim order by the Neutron backend, and prohibits the use of unexpected dim orders. ### Test plan As the testing requires the Neutron simulator which is not yet publicly available, the implementation was only tested internally in NXP. cc @robert-kalmar @JakeStevens @digantdesai
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
### Summary This PR enables the utilization of channels last dim order by the Neutron backend, and prohibits the use of unexpected dim orders. ### Test plan As the testing requires the Neutron simulator which is not yet publicly available, the implementation was only tested internally in NXP. cc @robert-kalmar @JakeStevens @digantdesai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the utilization of channels last dim order by the Neutron backend, and prohibits the use of unexpected dim orders.
Test plan
As the testing requires the Neutron simulator which is not yet publicly available, the implementation was only tested internally in NXP.
cc @robert-kalmar @JakeStevens @digantdesai