Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Dec 10, 2025

Add test for quantized lora. Expected file sizes:

full file:
-rw-r--r-- 1 lfq users 3051988096 Dec 10 11:34 qwen_lora_math_full.pte

program-data separated:
-rw-r--r-- 1 lfq users 2388436736 Dec  9 12:20 qwen_foundation.ptd
-rw-r--r-- 1 lfq users   40430544 Dec  9 12:20 qwen_lora_math.ptd
-rw-r--r-- 1 lfq users     810064 Dec  9 12:20 qwen_lora_math.pte

quantized:
-rw-r--r-- 1 lfq users  962094448 Dec 10 14:16 qwen_foundation_lora_q.ptd
-rw-r--r-- 1 lfq users   40430544 Dec 10 14:16 qwen_lora_math_q.ptd
-rw-r--r-- 1 lfq users     874912 Dec 10 14:16 qwen_lora_math_q.pte

quantized, no lora adapter:
-rw-r--r-- 1 lfq users  962094448 Dec 10 13:52 qwen_foundation_q.ptd
-rw-r--r-- 1 lfq users     635552 Dec 10 13:52 qwen_q.pte

Quantized lora weights are the same as non-quantized, as the rank is 16, and quantization for xnnpack works for group_size >= 32

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16188

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 489a942 with merge base c3a53f3 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2025
@lucylq lucylq force-pushed the lfq.qwen-lora-quantize-test branch from 4d2a878 to 7cf1347 Compare December 10, 2025 22:28
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq force-pushed the lfq.qwen-lora-quantize-test branch from 7cf1347 to 5a2fe64 Compare December 10, 2025 22:52
@lucylq lucylq requested a review from metascroy December 10, 2025 22:54
@lucylq lucylq marked this pull request as ready for review December 10, 2025 22:55
@lucylq lucylq force-pushed the lfq.qwen-lora-quantize-test branch from 5a2fe64 to 489a942 Compare December 11, 2025 00:02
@lucylq lucylq merged commit 56c9b2c into main Dec 11, 2025
309 of 312 checks passed
@lucylq lucylq deleted the lfq.qwen-lora-quantize-test branch December 11, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants