Skip to content

Conversation

@DrJessop
Copy link
Contributor

Summary:
Updated

  • FuseCascadedViewOps
  • ReplaceAtenConvolutionWithCadenceConvolutionPass
  • ReplaceTransposedConvWithLinearPass
  • ReplaceNopTransposeOrPermuteWithViewPass
  • ReplaceLinearWithFullyConnectedOpPass

to use the new efficient pass interface which also correctly sets the modified bit.

Also fix the transposed_im2row since numerical validation was failing for tests that introduced those ops.

Reviewed By: hsharma35

Differential Revision: D87837579

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16200

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 4 Unrelated Failures

As of commit 73363c8 with merge base 8eb2272 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 11, 2025

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87837579.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Dec 11, 2025
…entations (pytorch#16200)

Summary:

Updated
- FuseCascadedViewOps
- ReplaceAtenConvolutionWithCadenceConvolutionPass
- ReplaceTransposedConvWithLinearPass
- ReplaceNopTransposeOrPermuteWithViewPass
- ReplaceLinearWithFullyConnectedOpPass

to use the new efficient pass interface which also correctly sets the modified bit.

Also fix the transposed_im2row since numerical validation was failing for tests that introduced those ops.

Reviewed By: hsharma35

Differential Revision: D87837579
…entations (pytorch#16200)

Summary:

Updated
- FuseCascadedViewOps
- ReplaceAtenConvolutionWithCadenceConvolutionPass
- ReplaceTransposedConvWithLinearPass
- ReplaceNopTransposeOrPermuteWithViewPass
- ReplaceLinearWithFullyConnectedOpPass

to use the new efficient pass interface which also correctly sets the modified bit.

Also fix the transposed_im2row since numerical validation was failing for tests that introduced those ops.

Reviewed By: hsharma35

Differential Revision: D87837579
@meta-codesync meta-codesync bot merged commit 063b61f into pytorch:main Dec 12, 2025
136 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants