Using new test infra #16342
Using new test infra #16342
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16342
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the quantized_linear_out test from HiFi-specific test infrastructure to a new centralized testing framework. The change removes the old HiFi-specific test file that contained tests for quantized linear operations with int16 activations.
Key changes:
- Removed the HiFi-specific test file
test_op_quantized_linear_out.cppcontainingQuantizedLinearInt16Test
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
) Summary: # Context In D87935980, new infra was introduced so that we can test all backends at once with a single test. We want to migrate existing tests to this new framework. # This Diff Here, we migrate `quantized_linear_out` to use this new infra. When we ran ``` buck test fbsource//xplat/on_device_ai/Assistant/Jarvis/min_runtime/operators/test:test_quantized_linear_out_xtensa_Artemis_HiFi4_UT_v3 ``` we noticed that `op_quantized_linear_tie.cpp` doesn't have this fallback. Thus, we needed to add this fallback as well. Reviewed By: mcremon-meta Differential Revision: D89418382
RahulC7
force-pushed
the
export-D89418382
branch
from
5b2df73 to
962e1dc
Compare
) Summary: # Context In D87935980, new infra was introduced so that we can test all backends at once with a single test. We want to migrate existing tests to this new framework. # This Diff Here, we migrate `quantized_linear_out` to use this new infra. When we ran ``` buck test fbsource//xplat/on_device_ai/Assistant/Jarvis/min_runtime/operators/test:test_quantized_linear_out_xtensa_Artemis_HiFi4_UT_v3 ``` we noticed that `op_quantized_linear_tie.cpp` doesn't have this fallback. Thus, we needed to add this fallback as well. Reviewed By: mcremon-meta Differential Revision: D89418382
RahulC7
force-pushed
the
export-D89418382
branch
from
962e1dc to
f7e5bfd
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Summary:
Context
In D87935980, new infra was introduced so that we can test all backends at once with a single test. We want to migrate existing tests to this new framework.
This Diff
Here, we migrate
quantized_linear_outto use this new infra. When we ranwe noticed that
op_quantized_linear_tie.cppdoesn't have this fallback. Thus, we needed to add this fallback as well.Differential Revision: D89418382