Skip to content

Temporarily disable Samsung test jobs #16676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergennachin merged 1 commit into from
Jan 16, 2026
Merged

Temporarily disable Samsung test jobs #16676

mergennachin merged 1 commit into from
Jan 16, 2026

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Jan 16, 2026 •
edited
Loading

Disable test-samsung-models-linux due to edb (Exynos device bridge) failures and device reservation issues.

Root causes:

  • Device reservation not always successful
  • edb command execution failures
  • Path mismatches in runtime_executor.py

These jobs were blocking viable/strict from advancing.

Here's the history

https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=samsung

Copilot AI review requested due to automatic review settings January 16, 2026 23:33
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 16, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16676

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 114 Pending

As of commit 485d6ab with merge base d305410 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2026
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily disables two Samsung test jobs that are experiencing infrastructure failures to unblock the CI pipeline.

Changes:

  • Disabled test-samsung-quantmodels-linux job using if: false condition
  • Disabled test-samsung-models-linux job using if: false condition
  • Added comments explaining the reason for disabling (edb failures and device reservation issues)
  • Preserved original conditions as comments for easy re-enabling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergennachin mergennachin force-pushed the disable-samsung-tests branch from 2b4295e to 85963c1 Compare January 16, 2026 23:37
@mergennachin mergennachin mentioned this pull request Jan 16, 2026
Open
@mergennachin
Temporarily disable test-samsung-models-linux
485d6ab 
Disable test-samsung-models-linux due to edb (Exynos device bridge)
failures and device reservation issues.

Root causes:
- Device reservation not always successful
- edb command execution failures
- Path mismatches in runtime_executor.py

This job was blocking viable/strict from advancing.
Copilot AI review requested due to automatic review settings January 16, 2026 23:39
@mergennachin mergennachin force-pushed the disable-samsung-tests branch from 85963c1 to 485d6ab Compare January 16, 2026 23:39
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergennachin mergennachin merged commit 9cdc558 into main Jan 16, 2026
120 of 131 checks passed
@mergennachin mergennachin deleted the disable-samsung-tests branch January 16, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rascani rascani rascani approved these changes

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

@Jiseong-oh Jiseong-oh Awaiting requested review from Jiseong-oh

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mergennachin @rascani