Skip to content

Conversation

@winskuo-quic
Copy link
Collaborator

Summary

Test plan

UT added.

@winskuo-quic winskuo-quic requested a review from cccclai as a code owner January 19, 2026 03:17
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 19, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16686

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 220df29 with merge base af60367 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic
Copy link
Collaborator Author

winskuo-quic commented Jan 19, 2026

Hi @cccclai, @Gasoonjia,

This PR is to:

Please have a look.
Thanks

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

Copy link
Contributor

@Gasoonjia Gasoonjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work!

@cccclai cccclai merged commit 5ec362a into pytorch:main Jan 21, 2026
151 of 152 checks passed
@mergennachin
Copy link
Contributor

This is past the 1.1 branch cut, does it need to be cherry-picked? If so, please look at cherry-pick instructions at #16365

@winskuo-quic
Copy link
Collaborator Author

@pytorchbot cherry-pick --onto release/1.1 -c examples

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2026

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'examples' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@winskuo-quic
Copy link
Collaborator Author

@pytorchbot cherry-pick --onto release/1.1 -c regression

pytorchbot pushed a commit that referenced this pull request Jan 23, 2026
#16686)

### Summary

- Resolve Mainline Issue:
#16616 (comment)
- Fix MobileNetV3 Accuracy Issue
- Support drawing pydot graph so we can draw LLM models. SVG will stuck
when drawing LLM models.

### Test plan
UT added.

(cherry picked from commit 5ec362a)
@pytorchbot
Copy link
Collaborator

Cherry picking #16686

The cherry pick PR is at #16819 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants