Skip to content

Arm backend: Simplify using a16w8 quantizer in tests#16689

Merged
martinlsm merged 1 commit intopytorch:mainfrom
martinlsm:marlin-simplify-quantizer-usage
Jan 19, 2026
Merged

Arm backend: Simplify using a16w8 quantizer in tests#16689
martinlsm merged 1 commit intopytorch:mainfrom
martinlsm:marlin-simplify-quantizer-usage

Conversation

@martinlsm
Copy link
Copy Markdown
Collaborator

@martinlsm martinlsm commented Jan 19, 2026

Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com>
Change-Id: Ic39b1dfae116164d0114bda3c46f279ec82318ec
Copilot AI review requested due to automatic review settings January 19, 2026 08:19
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 19, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16689

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 894e617 with merge base 7492d0d (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2026
@martinlsm
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 19, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the use of a16w8 (16-bit activations, 8-bit weights) quantization in ARM backend tests by removing redundant helper functions and directly using the pipeline quantizer API.

Changes:

  • Removed local get_symmetric_a16w8_*_quantizer helper functions from each test file
  • Replaced pipeline.change_args("quantize", ...) calls with direct pipeline.quantizer.set_global(...) calls
  • Cleaned up unused imports (TOSAQuantizer, conftest, TosaSpecification, Quantize)
  • Updated copyright years to 2024-2026

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
backends/arm/test/ops/test_view.py Removed get_symmetric_a16w8_view_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls in 16a8w tests
backends/arm/test/ops/test_slice.py Removed get_symmetric_a16w8_slice_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls in 16a8w tests
backends/arm/test/ops/test_sigmoid.py Removed get_symmetric_a16w8_sigmoid_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls preserving epsilon=2**-16
backends/arm/test/ops/test_permute.py Removed get_symmetric_a16w8_permute_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls in 16a8w tests
backends/arm/test/ops/test_addmm.py Removed get_symmetric_a16w8_addmm_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls in 16a8w tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge if/when all Arm tests pass

@martinlsm martinlsm merged commit 3b16295 into pytorch:main Jan 19, 2026
305 of 309 checks passed
@martinlsm martinlsm deleted the marlin-simplify-quantizer-usage branch January 19, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants