Arm backend: Simplify using a16w8 quantizer in tests#16689
Arm backend: Simplify using a16w8 quantizer in tests#16689martinlsm merged 1 commit intopytorch:mainfrom
Conversation
Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: Ic39b1dfae116164d0114bda3c46f279ec82318ec
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16689
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 894e617 with merge base 7492d0d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label "partner: arm" |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR simplifies the use of a16w8 (16-bit activations, 8-bit weights) quantization in ARM backend tests by removing redundant helper functions and directly using the pipeline quantizer API.
Changes:
- Removed local
get_symmetric_a16w8_*_quantizerhelper functions from each test file - Replaced
pipeline.change_args("quantize", ...)calls with directpipeline.quantizer.set_global(...)calls - Cleaned up unused imports (TOSAQuantizer, conftest, TosaSpecification, Quantize)
- Updated copyright years to 2024-2026
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backends/arm/test/ops/test_view.py | Removed get_symmetric_a16w8_view_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls in 16a8w tests |
| backends/arm/test/ops/test_slice.py | Removed get_symmetric_a16w8_slice_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls in 16a8w tests |
| backends/arm/test/ops/test_sigmoid.py | Removed get_symmetric_a16w8_sigmoid_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls preserving epsilon=2**-16 |
| backends/arm/test/ops/test_permute.py | Removed get_symmetric_a16w8_permute_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls in 16a8w tests |
| backends/arm/test/ops/test_addmm.py | Removed get_symmetric_a16w8_addmm_quantizer helper, replaced with direct pipeline.quantizer.set_global() calls in 16a8w tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zingo
left a comment
There was a problem hiding this comment.
OK to merge if/when all Arm tests pass
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai