Skip to content

Fix backends toctree#16844

Closed
rascani wants to merge 4 commits intopytorch:mainfrom
rascani:fix-backends-toctree
Closed

Fix backends toctree#16844
rascani wants to merge 4 commits intopytorch:mainfrom
rascani:fix-backends-toctree

Conversation

@rascani
Copy link
Copy Markdown
Contributor

@rascani rascani commented Jan 23, 2026

Summary

Update the toctree links to match the backend table links.

Updates the toctree links to match the backend table links.
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jan 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16844

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e9abb72 with merge base 849b733 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani rascani requested a review from psiddh January 23, 2026 23:55
Copy link
Copy Markdown
Contributor

@psiddh psiddh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting it unblock. Once the doc build is done, lets verify all the links

@psiddh psiddh force-pushed the fix-backends-toctree branch from b935e1e to 0d60246 Compare January 26, 2026 07:23
@psiddh psiddh marked this pull request as ready for review January 26, 2026 07:24
@psiddh psiddh requested a review from mergennachin as a code owner January 26, 2026 07:24
Copilot AI review requested due to automatic review settings January 26, 2026 07:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates backend documentation navigation so the backend overview table and hidden toctree point to the same backend overview pages (using consistent relative paths).

Changes:

  • Updated backend overview table links to use consistent relative paths to backend overview pages.
  • Updated the hidden toctree in backends-overview.md to reference the same overview documents.
  • Removed a redundant hidden toctree from the NXP dim-order page.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/source/backends/nxp/nxp-dim-order.md Removes an extra hidden toctree from the page footer.
docs/source/backends-overview.md Aligns backend table links and the hidden toctree to the same backend overview documents using relative paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 90 to 91
--delegate --neutron_converter_flavor SDK_25_12 -m cifar10 \
--use_channels_last_dim_order
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example command uses --neutron_converter_flavor SDK_25_12, but the surrounding text references MCUXpresso SDK 25.06. Since the docs elsewhere indicate the converter flavor should match the MCUXpresso SDK version, this is confusing—please align the SDK version mentioned in the text and the converter flavor used in the command (pick one version and use it consistently).

Copilot uses AI. Check for mistakes.
Comment thread docs/source/backends-overview.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rascani
Copy link
Copy Markdown
Contributor Author

rascani commented Jan 26, 2026

Fixed in #16861

@rascani rascani closed this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants