Skip to content

Arm backend: Stop removing kwargs in quantizer#16931

Merged
Erik-Lundell merged 2 commits into
pytorch:mainfrom
Erik-Lundell:remove-removing-kwargs
Jan 29, 2026
Merged

Arm backend: Stop removing kwargs in quantizer#16931
Erik-Lundell merged 2 commits into
pytorch:mainfrom
Erik-Lundell:remove-removing-kwargs

Conversation

@Erik-Lundell
Copy link
Copy Markdown
Collaborator

@Erik-Lundell Erik-Lundell commented Jan 28, 2026

torchao now allows non-tensor kwargs when quantizing. Currently, I am not aware of any tensor kwargs so it is probably better to crash and handle it if we run into them instead of silently not quantizing them.

Add a test to make sure kwargs actually do survive quantization.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

torchao now allows non-tensor kwargs when quantizing.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I80b3f7be271b34413b38ccc3732da02840cb3ad8
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jan 28, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16931

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit ae9f549 with merge base c2317cb (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2026
@Erik-Lundell Erik-Lundell added release notes: none Do not include this in the release notes ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm labels Jan 28, 2026
@Erik-Lundell
Copy link
Copy Markdown
Collaborator Author

Unrelated issues, merging.

@Erik-Lundell Erik-Lundell merged commit 9c2246e into pytorch:main Jan 29, 2026
301 of 306 checks passed
@Erik-Lundell Erik-Lundell deleted the remove-removing-kwargs branch February 4, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants