Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16986
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ 2 Pending, 2 Unrelated FailuresAs of commit d2271e6 with merge base 651f2f2 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
e70ee91 to
744f05f
Compare
Summary: - Add ExportedProgramPassBase, which supports running passes on both `fx.GraphModule`s and `exir.ExportedProgram`s - Extend this class in `_ExportPassBase` so that any passes which import directly from `ExportPass` are immediately compatible with the current pass manager. - Create `LegacyPassWrapper` to auto-wrap passes not migrated to use ExportedProgramPassBase such that it works out of the box with EdgeProgramManager. Differential Revision: D91725222
744f05f to
3d3a362
Compare
Summary: - Adds support to _ExportPassBase to run passes on ExportedPrograms. Ensures that we can only run either call or call_exported_program, not both - Updates exir.PassManager to run on either exported programs or graph modules. Updates PassManagers which extend it to override the correct interfaces (minimal change, just a method renaming) - If we run the pass manager with an exported program, supports both graph module and exported program passes, but will always return an ExportedProgramPassResult - Updates transform to always call pass manager with an ExportedProgram, thus getting back an ExportedProgramPassResult. Differential Revision: D91725222
3d3a362 to
288e8ef
Compare
Summary: - Adds support to _ExportPassBase to run passes on ExportedPrograms. Ensures that we can only run either call or call_exported_program, not both - Updates exir.PassManager to add a new pass manager which operates on exported programs. This is done to ensure backwards compatibility, while allowing _program transformations to use either pass manager Differential Revision: D91725222
288e8ef to
e5a316a
Compare
Summary: - Adds support to _ExportPassBase to run passes on ExportedPrograms. Ensures that we can only run either call or call_exported_program, not both - Updates exir.PassManager to add a new pass manager which operates on exported programs. This is done to ensure backwards compatibility, while allowing _program transformations to use either pass manager Differential Revision: D91725222
e5a316a to
bb5f715
Compare
Summary: - Adds support to _ExportPassBase to run passes on ExportedPrograms. Ensures that we can only run either call or call_exported_program, not both - Updates exir.PassManager to add a new pass manager which operates on exported programs. This is done to ensure backwards compatibility, while allowing _program transformations to use either pass manager Differential Revision: D91725222
|
@DrJessop, is this PR still active? |
Yes it is, had to put it on the backburner for a bit, but coming back to it. Essentially, after further discussion, we would like to support not just passes on ExportedPrograms, but on EdgeProgramManagers themselves. |
bb5f715 to
96c7800
Compare
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - Creates an EdgeProgramManagerPassManager Reviewed By: larryliu0820 Differential Revision: D91725222
96c7800 to
693ad8c
Compare
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - Creates an EdgeProgramManagerPassManager Reviewed By: larryliu0820 Differential Revision: D91725222
Summary: Pull Request resolved: pytorch#16986 - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - Creates an EdgeProgramManagerPassManager Reviewed By: larryliu0820 Differential Revision: D91725222
45d3898 to
4b0a9c3
Compare
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
4b0a9c3 to
f0f8725
Compare
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
f0f8725 to
d5408d2
Compare
Summary: Pull Request resolved: pytorch#16986 - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
d5408d2 to
0480729
Compare
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
0480729 to
e9490bd
Compare
Summary: Pull Request resolved: pytorch#16986 - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
e9490bd to
5c8d0dd
Compare
5c8d0dd to
9e38ecc
Compare
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
9e38ecc to
388bc2b
Compare
Summary: Pull Request resolved: pytorch#16986 - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
388bc2b to
bf5aa36
Compare
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
bf5aa36 to
d2271e6
Compare
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
Summary: - Adds support to run to run passes on ExportedPrograms and EdgeProgramManager - EdgeProgramManager transform behaves basically like a pass manager Reviewed By: larryliu0820, ethansfng Differential Revision: D91725222
Summary:
Reviewed By: larryliu0820, ethansfng
Differential Revision: D91725222