Skip to content

Conversation

@chenweng-quic
Copy link
Collaborator

Summary

  • Currently all tests will push same libs, which is redundant. With this PR it only push once, and reduce execution time from two to three times for operator's tests.

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperator --device <device> --host <host> --model SM8650 --build_folder build-android --executorch_root . --artifact all_artifact

without optimization
image

with optimization
image

cc @cccclai @cbilgin

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 2, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17086

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit c922887 with merge base 2a570e0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 2, 2026
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin
Copy link
Contributor

@lucylq

Can you import internally and see if it fixed the internal CI tests.

Last week, @GregoryComer reverted (#17014) due to internal CI failures

@mergennachin
Copy link
Contributor

@GregoryComer when reverting, it would be good to provide more information about what the error was in internal CI tests. We can't share everything but providing something would be good than nothing.

@cccclai
Copy link
Contributor

cccclai commented Feb 2, 2026

can you rebase to main?

- Currently all tests will push same libs, which is redundant. With this PR they only push once, and reduce execution time from two to three times for non LLM tests.
- Fix failed unit tests
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Feb 3, 2026

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D92060877.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the internal CI failure and will try to merge again. @GregoryComer feel free to chime in

@cccclai cccclai merged commit b856198 into pytorch:main Feb 10, 2026
147 of 150 checks passed
Gasoonjia pushed a commit that referenced this pull request Feb 11, 2026
)

### Summary
- Currently all tests will push same libs, which is redundant. With this
PR it only push once, and reduce execution time from two to three times
for operator's tests.

### Test plan
```
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperator --device <device> --host <host> --model SM8650 --build_folder build-android --executorch_root . --artifact all_artifact
```
without optimization
<img width="429" height="136" alt="image"
src="https://github.com/user-attachments/assets/f52a167c-b665-47da-97b2-02f836f4858e"
/>

with optimization
<img width="442" height="130" alt="image"
src="https://github.com/user-attachments/assets/46366237-ec7b-4d38-b577-5677b3dafb36"
/>



cc @cccclai @cbilgin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants