-
Notifications
You must be signed in to change notification settings - Fork 836
Qualcomm AI Engine Direct - Optimize UT execution time re-submit #17086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17086
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit c922887 with merge base 2a570e0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
Can you import internally and see if it fixed the internal CI tests. Last week, @GregoryComer reverted (#17014) due to internal CI failures |
|
@GregoryComer when reverting, it would be good to provide more information about what the error was in internal CI tests. We can't share everything but providing something would be good than nothing. |
|
can you rebase to main? |
- Currently all tests will push same libs, which is redundant. With this PR they only push once, and reduce execution time from two to three times for non LLM tests. - Fix failed unit tests
7b2d046 to
c922887
Compare
cccclai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the internal CI failure and will try to merge again. @GregoryComer feel free to chime in
) ### Summary - Currently all tests will push same libs, which is redundant. With this PR it only push once, and reduce execution time from two to three times for operator's tests. ### Test plan ``` python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperator --device <device> --host <host> --model SM8650 --build_folder build-android --executorch_root . --artifact all_artifact ``` without optimization <img width="429" height="136" alt="image" src="https://github.com/user-attachments/assets/f52a167c-b665-47da-97b2-02f836f4858e" /> with optimization <img width="442" height="130" alt="image" src="https://github.com/user-attachments/assets/46366237-ec7b-4d38-b577-5677b3dafb36" /> cc @cccclai @cbilgin
Summary
Test plan
without optimization

with optimization

cc @cccclai @cbilgin