Skip to content

Arm backend: Fix ioquantization pass test#17099

Open
gggekov wants to merge 2 commits intopytorch:mainfrom
gggekov:fix_ioquant_pass
Open

Arm backend: Fix ioquantization pass test#17099
gggekov wants to merge 2 commits intopytorch:mainfrom
gggekov:fix_ioquant_pass

Conversation

@gggekov
Copy link
Collaborator

@gggekov gggekov commented Feb 2, 2026 •
edited by pytorch-bot bot
Loading

We need to use to_edge_transform_and_lower when
testing the QuantizeInputs/QuantizeOutputs passes

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@gggekov
Arm backend: Fix ioquantization pass test
def838a 
We need to use to_edge_transform_and_lower when
testing the QuantizeInputs/QuantizeOutputs passes

Change-Id: I585ef6279d360fd17cb0d95b84656d4cb1d52109
@gggekov gggekov requested a review from digantdesai as a code owner February 2, 2026 13:59
Copilot AI review requested due to automatic review settings February 2, 2026 13:59
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 2, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17099

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 40d07c5 with merge base 059c729 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 2, 2026
Copilot AI reviewed Feb 2, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the ioquantization pass test by enabling the use_to_edge_transform_and_lower flag when testing the QuantizeInputs/QuantizeOutputs passes in the Arm backend.

Changes:

  • Updated copyright year range to include 2026
  • Changed use_to_edge_transform_and_lower parameter from False to True in the test configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Feb 2, 2026
@zingo
Copy link
Collaborator

zingo commented Feb 4, 2026

Please wait to mergeto after #17200

@zingo
Copy link
Collaborator

zingo commented Feb 4, 2026

#17200 is merged, e.g. please merge if you want. or rebase if you also want that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mergennachin mergennachin mergennachin approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gggekov @zingo @mergennachin